Maintenance cleanup (#51)

Author: blink1073

.flake8

@@ -8,30 +8,12 @@ on:
     - cron: "0 8 * * *"
 
 jobs:
-  # Run "pre-commit run --all-files --hook-stage=manual"
   pre-commit:
-    name: Run pre-commit hook
     runs-on: ubuntu-latest
-    timeout-minutes: 5
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-      - name: Set up Python
-        uses: actions/setup-python@v3
-      - name: Run pre-commit
-        uses: pre-commit/[email protected]
-        with:
-          extra_args: --all-files --hook-stage=manual
-      - name: Help message if pre-commit fail
-        if: ${{ failure() }}
-        run: |
-          echo "You can install pre-commit hooks to automatically run formatting"
-          echo "on each commit with:"
-          echo "    pre-commit install"
-          echo "or you can run by hand on staged files with"
-          echo "    pre-commit run"
-          echo "or after-the-fact on already committed files with"
-          echo "    pre-commit run --all-files --hook-stage=manual"
+      - uses: actions/checkout@v2
+      - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+      - uses: jupyterlab/maintainer-tools/.github/actions/pre-commit@v1
 
   test:
     runs-on: ${{ matrix.os }}
@@ -46,6 +28,8 @@ jobs:
             python-version: "3.9"
           - os: ubuntu-latest
             python-version: "pypy-3.8"
+          - os: ubuntu-latest
+            python-version: "3.11-dev"
           - os: macos-latest
             python-version: "3.8"
     steps:
@@ -55,22 +39,23 @@ jobs:
         uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
       - name: Install the Python dependencies
         run: |
-          pip install -e ".[test]" codecov
+          pip install -e ".[test]"
       - name: List installed packages
         run: |
           pip freeze
           pip check
       - name: Run the tests with Coverage
         if: ${{ !startsWith(matrix.python-version, 'pypy') && !startsWith(runner.os, 'Windows') }}
         run: |
-          python -m pytest -vv --cov jupyter_server_terminals --cov-branch --cov-report term-missing:skip-covered
+          pytest -vv --cov jupyter_server_terminals --cov-branch --cov-report term-missing:skip-covered || pytest -vv --lf
       - name: Run the tests on pypy and Windows
         if: ${{ startsWith(matrix.python-version, 'pypy') || startsWith(runner.os, 'Windows') }}
         run: |
-          python -m pytest -vv
+          pytest -vv || pytest -vv --lf
       - name: Coverage
         if: ${{ !startsWith(matrix.python-version, 'pypy') && !startsWith(runner.os, 'Windows') }}
         run: |
+          pip install codecov
           codecov
 
   test_minimum_versions:
@@ -129,6 +114,21 @@ jobs:
         with:
           extra_test: 'jupyter server extension list 2>&1 | grep -ie "jupyter_server_terminals.*OK"'
 
+  check_release:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Base Setup
+        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+      - name: Install Dependencies
+        run: |
+          pip install -e .
+      - name: Check Release
+        uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
   check_links:
     runs-on: ubuntu-latest
     timeout-minutes: 10

.github/workflows/check-release.yml

@@ -52,10 +52,11 @@ repos:
         args: [--max-line-length=200]
         stages: [manual]
 
-  - repo: https://github.com/pycqa/flake8
-    rev: 5.0.4
+  - repo: https://github.com/john-hen/Flake8-pyproject
+    rev: 1.0.1
     hooks:
-      - id: flake8
+      - id: Flake8-pyproject
+        alias: flake8
         additional_dependencies:
           ["flake8-bugbear==22.6.22", "flake8-implicit-str-concat==0.2.0"]
         stages: [manual]

.github/workflows/test.yml

@@ -4,6 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "jupyter_server_terminals"
+readme = "README.md"
 dynamic = ["version"]
 license = { file = "LICENSE" }
 description = "A Jupyter Server Extension Providing Terminals."
@@ -29,10 +30,6 @@ dependencies = [
 name = "Jupyter Development Team"
 email = "[email protected]"
 
-[project.readme]
-file = "README.md"
-content-type = "text/markdown"
-
 [project.urls]
 Homepage = "https://jupyter.org"
 
@@ -86,6 +83,23 @@ warn_redundant_casts = true
 warn_return_any = true
 warn_unused_ignores = true
 
-
-[tool.jupyter-releaser]
-skip = ["check-links"]
+[tool.flake8]
+ignore = "E501, W503, E402"
+builtins = "c, get_config"
+exclude = [
+    ".cache",
+    ".github",
+    "docs",
+    "setup.py",
+]
+enable-extensions = "G"
+extend-ignore = [
+    "G001", "G002", "G004", "G200", "G201", "G202",
+    # black adds spaces around ':'
+    "E203",
+]
+per-file-ignores = [
+    # B011: Do not call assert False since python -O removes these calls
+    # F841 local variable 'foo' is assigned to but never used
+    "tests/*: B011", "F841",
+]