add flake8 and pytest settings

Author: blink1073

.pre-commit-config.yaml

@@ -48,16 +48,16 @@ repos:
       - id: doc8
         args: [--max-line-length=200]
 
-  # - repo: https://github.com/pycqa/flake8
-  #   rev: 4.0.1
-  #   hooks:
-  #     - id: flake8
-  #       additional_dependencies:
-  #         [
-  #           "flake8-bugbear==20.1.4",
-  #           "flake8-logging-format==0.6.0",
-  #           "flake8-implicit-str-concat==0.2.0",
-  #         ]
+  - repo: https://github.com/pycqa/flake8
+    rev: 4.0.1
+    hooks:
+      - id: flake8
+        additional_dependencies:
+          [
+            "flake8-bugbear==20.1.4",
+            "flake8-logging-format==0.6.0",
+            "flake8-implicit-str-concat==0.2.0",
+          ]
 
   - repo: https://github.com/sirosen/check-jsonschema
     rev: 0.14.1

docs/source/conf.py

@@ -268,16 +268,7 @@
 
 # -- Options for LaTeX output ---------------------------------------------
 
-latex_elements = {
-    # The paper size ('letterpaper' or 'a4paper').
-    #'papersize': 'letterpaper',
-    # The font size ('10pt', '11pt' or '12pt').
-    #'pointsize': '10pt',
-    # Additional stuff for the LaTeX preamble.
-    #'preamble': '',
-    # Latex figure (float) alignment
-    #'figure_align': 'htbp',
-}
+latex_elements = {}
 
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title,

jupyter_server_terminals/app.py

@@ -11,15 +11,6 @@
     from jupyter_server.extension.application import ExtensionApp
     from jupyter_server.transutils import trans
     from jupyter_server.utils import run_sync_in_loop
-
-    # Tolerate missing terminado package.
-    try:
-        from .terminalmanager import TerminalManager
-
-        terminado_available = True
-    except ImportError:
-        terminado_available = False
-
 except ModuleNotFoundError:
     raise ModuleNotFoundError("Jupyter Server must be installed to use this extension.")
 
@@ -43,9 +34,7 @@ class TerminalsExtensionApp(ExtensionApp):
 
     def initialize_settings(self):
         self.initialize_configurables()
-        self.settings.update(
-            dict(terminals_available=terminado_available, terminal_manager=self.terminal_manager)
-        )
+        self.settings.update(dict(terminals_available=True, terminal_manager=self.terminal_manager))
 
     def initialize_configurables(self):
         if os.name == "nt":

jupyter_server_terminals/terminalmanager.py

@@ -111,7 +111,7 @@ def _initialize_culler(self):
         """
         if not self._initialized_culler and self.cull_inactive_timeout > 0:
             if self._culler_callback is None:
-                loop = IOLoop.current()
+                _ = IOLoop.current()
                 if self.cull_interval <= 0:  # handle case where user set invalid value
                     self.log.warning(
                         "Invalid value for 'cull_interval' detected (%s) - using default value (%s).",

pyproject.toml

@@ -6,10 +6,19 @@ build-backend = "jupyter_packaging.build_api"
 ignore = [""]
 
 [tool.pytest.ini_options]
-addopts = "--doctest-modules"
+addopts = "-raXs --durations 10 --color=yes --doctest-modules"
 testpaths = [
     "tests/"
 ]
+timeout = 300
+# Restore this setting to debug failures
+# timeout_method = "thread"
+filterwarnings = [
+  "error",
+  # From tornado
+  "ignore:unclosed <socket.socket:ResourceWarning",
+  "ignore:There is no current event loop:DeprecationWarning",
+]
 
 [tool.jupyter-releaser]
 skip = ["check-links"]

setup.cfg

@@ -36,6 +36,7 @@ test =
     pytest>=6.0
     pytest_tornasync
     pytest-cov
+    pytest-timeout
     jupyter_server[test]>=1
 
 [options.packages.find]
@@ -46,10 +47,19 @@ etc/jupyter/jupyter_server_config.d =
     jupyter-config/jupyter_server_terminals.json
 
 [flake8]
-ignore = E, C, W, F403, F811, F841, E402, I100, I101, D400
+ignore = E501, W503, E402
 builtins = c, get_config
 exclude =
     .cache,
     .github,
     docs,
     setup.py
+enable-extensions = G
+extend-ignore =
+    G001, G002, G004, G200, G201, G202,
+    # black adds spaces around ':'
+    E203,
+per-file-ignores =
+    # B011: Do not call assert False since python -O removes these calls
+    # F841 local variable 'foo' is assigned to but never used
+    tests/*: B011, F841

tests/test_terminal.py

@@ -171,7 +171,7 @@ async def test_culling(jp_server_config, jp_fetch, jp_cleanup_subprocesses):
     last_activity = term["last_activity"]
 
     culled = False
-    for i in range(CULL_TIMEOUT + CULL_INTERVAL * 2):
+    for _ in range(CULL_TIMEOUT + CULL_INTERVAL * 2):
         try:
             resp = await jp_fetch(
                 "api",