Handle jupyter core warning (#58)

* handle jupyter core warning

* remove jp_cleanup_subprocesses

Author: blink1073

pyproject.toml

@@ -64,6 +64,8 @@ filterwarnings = [
   "module:make_current is deprecated:DeprecationWarning",
   "module:clear_current is deprecated:DeprecationWarning",
   "module:There is no current event loop:DeprecationWarning",
+  # From juypter core
+  "module:Jupyter is migrating its paths to use standard platformdirs:DeprecationWarning",
 ]
 
 [tool.mypy]

tests/test_auth.py

@@ -123,7 +123,6 @@ async def test_authorized_requests(
     io_loop,
     send_request,
     jp_serverapp,
-    jp_cleanup_subprocesses,
     method,
     url,
     body,
@@ -156,5 +155,3 @@ async def test_authorized_requests(
             continue
         assert code in expected_codes
         break
-
-    await jp_cleanup_subprocesses()

tests/test_terminal.py

@@ -61,7 +61,7 @@ async def test_no_terminals(jp_fetch):
     assert len(data) == 0
 
 
-async def test_terminal_create(jp_fetch, jp_cleanup_subprocesses):
+async def test_terminal_create(jp_fetch):
     resp = await jp_fetch(
         "api",
         "terminals",
@@ -84,10 +84,9 @@ async def test_terminal_create(jp_fetch, jp_cleanup_subprocesses):
     del data[0]["last_activity"]
     del term["last_activity"]
     assert data[0] == term
-    await jp_cleanup_subprocesses()
 
 
-async def test_terminal_create_with_kwargs(jp_fetch, terminal_path, jp_cleanup_subprocesses):
+async def test_terminal_create_with_kwargs(jp_fetch, terminal_path):
     resp_create = await jp_fetch(
         "api",
         "terminals",
@@ -110,12 +109,9 @@ async def test_terminal_create_with_kwargs(jp_fetch, terminal_path, jp_cleanup_s
     data = json.loads(resp_get.body.decode())
 
     assert data["name"] == term_name
-    await jp_cleanup_subprocesses()
 
 
-async def test_terminal_create_with_cwd(
-    jp_fetch, jp_ws_fetch, terminal_path, jp_cleanup_subprocesses
-):
+async def test_terminal_create_with_cwd(jp_fetch, jp_ws_fetch, terminal_path):
     resp = await jp_fetch(
         "api",
         "terminals",
@@ -153,11 +149,10 @@ async def test_terminal_create_with_cwd(
     ws.close()
 
     assert os.path.basename(terminal_path) in message_stdout
-    await jp_cleanup_subprocesses()
 
 
 async def test_terminal_create_with_relative_cwd(
-    jp_fetch, jp_ws_fetch, jp_root_dir, terminal_root_dir, jp_cleanup_subprocesses
+    jp_fetch, jp_ws_fetch, jp_root_dir, terminal_root_dir
 ):
     resp = await jp_fetch(
         "api",
@@ -197,10 +192,9 @@ async def test_terminal_create_with_relative_cwd(
 
     expected = terminal_root_dir.name if sys.platform == "win32" else str(terminal_root_dir)
     assert expected in message_stdout
-    await jp_cleanup_subprocesses()
 
 
-async def test_terminal_create_with_bad_cwd(jp_fetch, jp_ws_fetch, jp_cleanup_subprocesses):
+async def test_terminal_create_with_bad_cwd(jp_fetch, jp_ws_fetch):
     non_existing_path = "/tmp/path/to/nowhere"
     resp = await jp_fetch(
         "api",
@@ -239,7 +233,6 @@ async def test_terminal_create_with_bad_cwd(jp_fetch, jp_ws_fetch, jp_cleanup_su
     ws.close()
 
     assert non_existing_path not in message_stdout
-    await jp_cleanup_subprocesses()
 
 
 async def test_culling_config(jp_configurable_serverapp):
@@ -252,7 +245,7 @@ async def test_culling_config(jp_configurable_serverapp):
 
 
 @pytest.mark.skipif(os.name == "nt", reason="Not currently working on Windows")
-async def test_culling(jp_fetch, jp_cleanup_subprocesses):
+async def test_culling(jp_fetch):
     # POST request
     resp = await jp_fetch(
         "api",
@@ -282,4 +275,3 @@ async def test_culling(jp_fetch, jp_cleanup_subprocesses):
             await asyncio.sleep(1)
 
     assert culled
-    await jp_cleanup_subprocesses()