Skip to content

Commit f8e74ff

Browse files
committed
-
1 parent 46c6814 commit f8e74ff

File tree

5 files changed

+18
-14
lines changed

5 files changed

+18
-14
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
run: |
5050
micromamba install pip nodejs=18
5151
pip install ".[test]"
52+
pip install "pycrdt >=0.12.1"
5253
- name: Build JavaScript assets
5354
working-directory: javascript
5455
run: |

jupyter_ydoc/ybasedoc.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class YBaseDoc(ABC):
2929

3030
_ydoc: YDoc
3131
_ystate: YState
32-
_subscriptions: Dict[Any, Subscription]
32+
_subscriptions: dict[Any, Subscription]
3333
_undo_manager: UndoManager
3434

3535
def __init__(self, ydoc: YDoc | Doc | None = None, awareness: Awareness | None = None):
@@ -121,7 +121,7 @@ def dirty(self) -> bool | None:
121121
"""
122122
try:
123123
return self._ystate.dirty
124-
except:
124+
except AttributeError:
125125
return None
126126

127127
@dirty.setter
@@ -144,7 +144,7 @@ def hash(self) -> str | None:
144144
"""
145145
try:
146146
return self._ystate.hash
147-
except:
147+
except AttributeError:
148148
return None
149149

150150
@hash.setter
@@ -167,7 +167,7 @@ def path(self) -> str | None:
167167
"""
168168
try:
169169
return self._ystate.path
170-
except:
170+
except AttributeError:
171171
return None
172172

173173
@path.setter

jupyter_ydoc/yblob.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def get(self) -> bytes:
7070
"""
7171
try:
7272
return self._ysource.bytes
73-
except:
73+
except AttributeError:
7474
return b""
7575

7676
def set(self, value: bytes) -> None:

jupyter_ydoc/ynotebook.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def cell_number(self) -> int:
141141
"""
142142
return len(self._ycells)
143143

144-
def get_cell(self, index: int) -> Dict[str, Any]:
144+
def get_cell(self, index: int) -> dict[str, Any]:
145145
"""
146146
Returns a cell.
147147
@@ -166,7 +166,7 @@ def get_cell(self, index: int) -> Dict[str, Any]:
166166
del cell["attachments"]
167167
return cell
168168

169-
def append_cell(self, value: Dict[str, Any]) -> None:
169+
def append_cell(self, value: dict[str, Any]) -> None:
170170
"""
171171
Appends a cell.
172172
@@ -176,7 +176,7 @@ def append_cell(self, value: Dict[str, Any]) -> None:
176176
ycell = self.create_ycell(value)
177177
self._ycells.append(ycell)
178178

179-
def set_cell(self, index: int, value: Dict[str, Any]) -> None:
179+
def set_cell(self, index: int, value: dict[str, Any]) -> None:
180180
"""
181181
Sets a cell into indicated position.
182182
@@ -189,7 +189,7 @@ def set_cell(self, index: int, value: Dict[str, Any]) -> None:
189189
ycell = self.create_ycell(value)
190190
self.set_ycell(index, ycell)
191191

192-
def create_ycell(self, value: Dict[str, Any]) -> YCell:
192+
def create_ycell(self, value: dict[str, Any]) -> YCell:
193193
"""
194194
Creates YCell with the content of the cell.
195195
@@ -239,7 +239,7 @@ def set_ycell(self, index: int, ycell: YCell) -> None:
239239
"""
240240
self._ycells[index] = ycell
241241

242-
def get(self) -> Dict:
242+
def get(self) -> dict:
243243
"""
244244
Returns the content of the document.
245245
@@ -269,7 +269,7 @@ def get(self) -> Dict:
269269
nbformat_minor=int(meta.get("nbformat_minor", 0)),
270270
)
271271

272-
def set(self, value: Dict) -> None:
272+
def set(self, value: dict) -> None:
273273
"""
274274
Sets the content of the document.
275275
@@ -306,9 +306,11 @@ def set(self, value: Dict) -> None:
306306
ymetadata = YMetadata()
307307
self._ymeta.metadata = ymetadata
308308
metadata = nb.get("metadata", {})
309-
# ymetadata.language_info = asdict(LanguageInfo(**metadata.get("language_info", {"name": ""})))
309+
# ymetadata.language_info =
310+
# asdict(LanguageInfo(**metadata.get("language_info", {"name": ""})))
310311
ymetadata.language_info = metadata.get("language_info", {"name": ""})
311-
# ymetadata.kernelspec = asdict(Kernelspec(**metadata.get("kernelspec", {"name": "", "display_name": ""})))
312+
# ymetadata.kernelspec =
313+
# asdict(Kernelspec(**metadata.get("kernelspec", {"name": "", "display_name": ""})))
312314
ymetadata.kernelspec = metadata.get("kernelspec", {"name": "", "display_name": ""})
313315

314316
def observe(self, callback: Callable[[str, Any], None]) -> None:

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ requires-python = ">=3.8"
1313
keywords = ["jupyter", "pycrdt", "yjs"]
1414
dependencies = [
1515
"importlib_metadata >=3.6; python_version<'3.10'",
16-
"pycrdt >=0.12.1,<0.13.0",
16+
# "pycrdt >=0.12.1,<0.13.0",
17+
"pycrdt >=0.10.1,<0.11.0",
1718
]
1819

1920
[[project.authors]]

0 commit comments

Comments
 (0)