Merge pull request #284 from kevin-bates/enable-custom-error-messages

Add reason argument to set_status() so that custom messages flow

Author: parente

.gitignore

@@ -56,5 +56,8 @@ docs/_build/
 # PyBuilder
 target/
 
+# PyCharm
+.idea/
+
 .DS_Store
 .ipynb_checkpoints/

kernel_gateway/mixins.py

@@ -125,5 +125,5 @@ def write_error(self, status_code, **kwargs):
                 reply['reason'] = custom_reason
 
         self.set_header('Content-Type', 'application/json')
-        self.set_status(status_code)
+        self.set_status(status_code, reason=reply['reason'])
         self.finish(json.dumps(reply))

kernel_gateway/tests/test_mixins.py

@@ -137,12 +137,18 @@ def __init__(self):
         self.headers = {}
         self.response = None
         self.status_code = None
+        self.reason = None
 
     def finish(self, response):
         self.response = response
 
-    def set_status(self, status_code):
+    def set_status(self, status_code, reason=None):
+        # The reason parameter is essentially ignored, but necessary in the signature
+        # in order for custom messages to be returned to the client from tornado.
+        # Tornado's set_status method takes both parameters setting internal members
+        # to both values.  For now, we'll set the member but not use it.
         self.status_code = status_code
+        self.reason = reason
 
     def set_header(self, name, value):
         self.headers[name] = value