Merge pull request #64 from martinRenou/fix_ndarray_issue

Component: Fix NBArrayWidget use case

Author: martinRenou

.github/workflows/main.yml

@@ -30,7 +30,7 @@ jobs:
         conda-channels: conda-forge
 
     - name: Conda install dependencies
-      run: conda install python=${{ matrix.python-version }} pip nodejs=13 ipywidgets jupyter jupyterlab vtk flake8 pytest
+      run: conda install python=${{ matrix.python-version }} pip nodejs=13 ipywidgets jupyter jupyterlab vtk flake8 pytest ipydatawidgets
 
     - name: Install ipygany
       run: pip install -e .

ipygany/ipygany.py

@@ -52,10 +52,10 @@ def __init__(self, name, array, **kwargs):
         super(Component, self).__init__(name=name, array=array, **kwargs)
 
         if self.min is None:
-            self.min = np.min(self.array)
+            self.min = np.min(self.array) if not isinstance(self.array, Widget) else np.min(self.array.array)
 
         if self.max is None:
-            self.max = np.max(self.array)
+            self.max = np.max(self.array) if not isinstance(self.array, Widget) else np.max(self.array.array)
 
 
 class Data(_GanyWidgetBase):

tests/test_ipygany.py

@@ -2,6 +2,8 @@
 
 import numpy as np
 
+from ipydatawidgets import NDArrayWidget
+
 from ipygany import PolyMesh, Data, Component
 
 
@@ -56,3 +58,9 @@ def test_component_creation():
     assert comp.name == 'z'
     assert comp.min == 1.
     assert comp.max == 3.
+
+    comp = Component('z', NDArrayWidget(np.array([1., 2., 3.])))
+
+    assert comp.name == 'z'
+    assert comp.min == 1.
+    assert comp.max == 3.