Skip to content

Commit 6ba975e

Browse files
Merge pull request #120 from SylvainCorlay/fixup-jlab-extension
Fixup Jupyterlab extension for 0.4.0
2 parents 03a95cd + d7e8b85 commit 6ba975e

File tree

5 files changed

+19
-30
lines changed

5 files changed

+19
-30
lines changed

js/src/extension.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44

55
// Configure requirejs
66
if (window['require'] !== undefined) {
7-
window['require'].config({
8-
map: {
9-
"*" : {
10-
"ipysheet": "nbextensions/ipysheet/index",
11-
"jupyter-js-widgets": "nbextensions/jupyter-js-widgets/extension"
12-
}
13-
}
14-
});
7+
window['require'].config({
8+
map: {
9+
"*" : {
10+
"ipysheet": "nbextensions/ipysheet/index",
11+
"jupyter-js-widgets": "nbextensions/jupyter-js-widgets/extension"
12+
}
13+
}
14+
});
1515
}
1616

1717
// Export the required load_ipython_extention

js/src/labplugin.ts

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import * as sheet from './sheet';
2-
import * as renderer from './renderer';
31
import * as base from '@jupyter-widgets/base';
42
import {version} from './version';
3+
import * as sheet from './sheet';
54

65
const ipysheetPlugin = {
76
id: 'ipysheet',
@@ -16,17 +15,4 @@ const ipysheetPlugin = {
1615
autoStart: true
1716
};
1817

19-
const rendererPlugin = {
20-
id: 'ipysheet:renderer',
21-
requires: [base.IJupyterWidgetRegistry],
22-
activate: function(app, widgets) {
23-
widgets.registerWidget({
24-
name: 'ipysheet/renderer',
25-
version: version,
26-
exports: renderer
27-
});
28-
},
29-
autoStart: true
30-
};
31-
32-
export default [ipysheetPlugin, rendererPlugin];
18+
export default ipysheetPlugin;

js/src/renderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as widgets from '@jupyter-widgets/base';
22
import * as Handsontable from 'handsontable';
33
import {extend} from 'lodash';
4-
import {version, semver_range} from './version';
4+
import {semver_range} from './version';
55
import {safeEval} from './worker_eval';
66

77
let RendererModel = widgets.WidgetModel.extend({
@@ -29,5 +29,5 @@ let RendererModel = widgets.WidgetModel.extend({
2929
});
3030

3131
export {
32-
RendererModel, version
32+
RendererModel
3333
};

js/src/sheet.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
import * as widgets from '@jupyter-widgets/base';
22
import {cloneDeep, extend, includes as contains, each, debounce, times, map, unzip as transpose} from 'lodash';
33
import {semver_range} from './version';
4+
import {RendererModel} from './renderer';
45
import './widget_cell_type';
6+
57
// @ts-ignore
68
import * as Handsontable from 'handsontable';
79

10+
// CSS
811
import 'pikaday/css/pikaday.css';
912
import 'handsontable/dist/handsontable.min.css';
10-
import '@jupyter-widgets/controls/css/materialcolors.css'
11-
import '@jupyter-widgets/controls/css/labvariables.css'
13+
import '@jupyter-widgets/controls/css/materialcolors.css';
14+
import '@jupyter-widgets/controls/css/labvariables.css';
1215
import '../css/custom.css';
1316

1417

@@ -514,5 +517,5 @@ export {
514517
SheetModel,
515518
SheetView,
516519
CellRangeModel,
517-
Handsontable
520+
RendererModel
518521
};

js/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"inlineSourceMap": true
1313
},
1414
"include": [
15-
"./src/**/*",
15+
"./src/**/*"
1616
],
1717
"exclude": [
1818
"node_modules",

0 commit comments

Comments
 (0)