Fix embedding (#91)

* export handsontable from ipysheet, and make embedded renderer work from that

Author: maartenbreddels

js/karma.conf.js

@@ -29,6 +29,7 @@ module.exports = function (config) {
             mode: 'development',
             resolve: {
                 extensions: ['.js'],
+                alias: {ipysheet$: path.resolve(__dirname, './lib/index')}
             },
         },
         reporters: ['progress', 'mocha'],

js/package.json

@@ -3,7 +3,7 @@
   "version": "0.3.2",
   "description": "Spreadsheet in the Jupyter notebook",
   "author": "Maarten A. Breddels",
-  "main": "lib/src/index.js",
+  "main": "lib/index.js",
   "repository": {
     "type": "git",
     "url": "https://github.com/QuantStack/ipysheet.git"

js/src/embed.ts

@@ -7,3 +7,5 @@
 // Export widget models and views, and the npm package version number.
 export * from './sheet';
 export {version} from './version';
+import * as Handsontable from 'handsontable';
+export { Handsontable };

js/src/extension.ts

@@ -8,7 +8,6 @@ if (window['require'] !== undefined) {
         map: {
             "*" : {
                 "ipysheet": "nbextensions/ipysheet/index",
-                "handsontable": "nbextensions/ipysheet/handsontable",
                 "jupyter-js-widgets": "nbextensions/jupyter-js-widgets/extension"
             }
         }

js/src/handsontable_mod.ts

@@ -10,3 +10,5 @@
 // Export widget models and views, and the npm package version number.
 export * from './sheet';
 export { version } from './version';
+import * as Handsontable from 'handsontable';
+export { Handsontable };

js/src/index.ts

@@ -2,7 +2,7 @@ import * as widgets  from '@jupyter-widgets/base';
 import {extend} from 'lodash';
 import {version, semver_range} from './version';
 // @ts-ignore
-import * as Handsontable from 'handsontable';
+import {Handsontable} from 'ipysheet';
 
 
 let RendererModel = widgets.WidgetModel.extend({

js/src/renderer.ts

@@ -66,7 +66,7 @@ module.exports = [
         module: {
             rules: rules
         },
-        externals: ['@jupyter-widgets/base', 'handsontable']
+        externals: ['@jupyter-widgets/base']
     },
     {
         // same for render
@@ -81,7 +81,7 @@ module.exports = [
         module: {
             rules: rules
         },
-        externals: ['@jupyter-widgets/base', 'handsontable']
+        externals: ['@jupyter-widgets/base', 'ipysheet']
     },
     {
         // Embeddable ipysheet bundle
@@ -109,7 +109,7 @@ module.exports = [
         module: {
             rules: rules
         },
-        externals: ['@jupyter-widgets/base', 'handsontable']
+        externals: ['@jupyter-widgets/base']
     },
     {
         // same for renderer
@@ -124,17 +124,6 @@ module.exports = [
         module: {
             rules: rules
         },
-        externals: ['@jupyter-widgets/base', 'handsontable']
+        externals: ['@jupyter-widgets/base', 'ipysheet']
     },
-    {
-        entry: './node_modules/handsontable/dist/handsontable.min.js',
-        output: {
-            filename: 'handsontable.js',
-            path: path.resolve(__dirname, '../ipysheet/static'),
-            libraryTarget: 'amd'
-        },
-        module: {
-            rules: rules
-        },
-    }
 ];

js/webpack.config.js

@@ -70,8 +70,7 @@ class NPM(Command):
         os.path.join(here, 'ipysheet', 'static', 'extension.js'),
         os.path.join(here, 'ipysheet', 'static', 'index.js'),
         os.path.join(here, 'ipysheet', 'static', 'extension-renderer.js'),
-        os.path.join(here, 'ipysheet', 'static', 'renderer.js'),
-        os.path.join(here, 'ipysheet', 'static', 'handsontable.js')
+        os.path.join(here, 'ipysheet', 'static', 'renderer.js')
     ]
 
     def initialize_options(self):
@@ -128,7 +127,6 @@ def run(self):
     'include_package_data': True,
     'data_files': [
         ('share/jupyter/nbextensions/ipysheet', [
-            'ipysheet/static/handsontable.js',
             'ipysheet/static/extension.js',
             'ipysheet/static/index.js',
             'ipysheet/static/index.js.map',