Skip to content

Commit 0c2c4ce

Browse files
committed
Remove unnecessary hitTest
Signed-off-by: Itay Dafna <[email protected]>
1 parent ca4fae7 commit 0c2c4ce

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

js/core/filterMenu.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import { DataModel } from '@lumino/datagrid';
88

99
import { Signal, ISignal } from '@lumino/signaling';
1010

11-
import { ElementExt } from '@lumino/domutils';
12-
1311
import { Message, MessageLoop, ConflatableMessage } from '@lumino/messaging';
1412

1513
import { BasicMouseHandler } from '@lumino/datagrid';
@@ -460,10 +458,7 @@ export class InteractiveFilterDialog extends BoxPanel {
460458
*/
461459
protected _evtMouseDown(event: MouseEvent) {
462460
// Close the menu if a click is detected anywhere else
463-
if (
464-
!ElementExt.hitTest(this.node, event.clientX, event.clientY) &&
465-
!this.node.contains(event.target as HTMLElement)
466-
) {
461+
if (!this.node.contains(event.target as HTMLElement)) {
467462
this.close();
468463
}
469464
}

0 commit comments

Comments
 (0)