Skip to content

Commit 1a61cc7

Browse files
jgunstonemartinRenou
authored andcommitted
🚀 create a selected_visible_cell_iterator property
this allows users to use the SelectionHelper on visible data only Signed-off-by: jgunstone <[email protected]>
1 parent 23b6287 commit 1a61cc7

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

ipydatagrid/datagrid.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -760,11 +760,11 @@ def selected_cells(self):
760760
return SelectionHelper(
761761
self._data, self.selections, self.selection_mode
762762
).all()
763-
763+
764764
@property
765-
def selected_cell_values(self):
765+
def selected_visible_cell_iterator(self):
766766
"""
767-
List of values for all selected cells.
767+
An iterator to traverse selected visible cells one by one.
768768
"""
769769
# Copy of the front-end data model
770770
view_data = self.get_visible_data()
@@ -776,10 +776,14 @@ def selected_cell_values(self):
776776
view_data_object = self.generate_data_object(
777777
view_data, "ipydguuid", index_key
778778
)
779+
return SelectionHelper(view_data_object, self.selections, self.selection_mode)
779780

780-
return SelectionHelper(
781-
view_data_object, self.selections, self.selection_mode
782-
).all_values()
781+
@property
782+
def selected_cell_values(self):
783+
"""
784+
List of values for all selected cells.
785+
"""
786+
return self.selected_visible_cell_iterator.all_values()
783787

784788
@property
785789
def selected_cell_iterator(self):

0 commit comments

Comments
 (0)