Skip to content

Commit 9efa755

Browse files
committed
Resetting column_header will now display correctly on the grid
Signed-off-by: Itay Dafna <[email protected]>
1 parent 251585d commit 9efa755

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

js/datagrid.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -600,9 +600,16 @@ export class DataGridView extends DOMWidgetView {
600600
});
601601
}
602602

603+
const hasHeaderRenderer = this.model.get('header_renderer') !== null;
603604
let columnHeaderRenderer = null;
604-
if (this.header_renderer) {
605+
if (this.header_renderer && hasHeaderRenderer) {
605606
columnHeaderRenderer = this.header_renderer.renderer;
607+
} else {
608+
columnHeaderRenderer = new TextRenderer({
609+
font: '12px sans-serif',
610+
textColor: Theme.getFontColor(),
611+
backgroundColor: Theme.getBackgroundColor(2),
612+
});
606613
}
607614

608615
let cornerHeaderRenderer = null;
@@ -616,10 +623,7 @@ export class DataGridView extends DOMWidgetView {
616623
});
617624

618625
this.grid.defaultRenderer = defaultRenderer;
619-
// Set column header renderer only if received from backend
620-
if (columnHeaderRenderer) {
621-
this.grid.columnHeaderRenderer = columnHeaderRenderer;
622-
}
626+
this.grid.columnHeaderRenderer = columnHeaderRenderer;
623627

624628
if (cornerHeaderRenderer) {
625629
this.grid.cornerHeaderRenderer = cornerHeaderRenderer;

0 commit comments

Comments
 (0)