Skip to content

Commit a741ec4

Browse files
authored
Merge pull request #134 from mbektasbbg/fix_scrollbar_in_notebook
fix for scrollbar icons not showing in jupyter notebook
2 parents 9671790 + 1569135 commit a741ec4

File tree

3 files changed

+40
-2
lines changed

3 files changed

+40
-2
lines changed

package-lock.json

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@
9898
"typescript": "~3.6.4",
9999
"webpack": "^4.20.2",
100100
"webpack-cli": "^3.1.2",
101-
"svg-url-loader": "~3.0.3"
101+
"svg-url-loader": "~3.0.3",
102+
"url-loader": "^4.1.0"
102103
},
103104
"jupyterlab": {
104105
"extension": "lib/plugin"

webpack.config.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,25 @@
11
const path = require('path');
22
const version = require('./package.json').version;
33

4+
const luminoThemeImages = /^.*@lumino\/default-theme.*.png$/;
5+
46
// Custom webpack rules
57
const rules = [
68
{ test: /\.ts$/, loader: 'ts-loader' },
79
{ test: /\.js$/, loader: 'source-map-loader' },
810
{ test: /\.css$/, use: ['style-loader', 'css-loader']},
9-
{ test: /\.(jpg|png|gif)$/, use: ['file-loader']},
11+
{
12+
test: luminoThemeImages,
13+
issuer: { test: /\.css$/ },
14+
use: {
15+
loader: 'url-loader'
16+
}
17+
},
18+
{
19+
test: /\.(jpg|png|gif)$/,
20+
exclude: luminoThemeImages,
21+
use: ['file-loader']
22+
},
1023
{
1124
test: /\.svg(\?v=\d+\.\d+\.\d+)?$/,
1225
issuer: { test: /\.css$/ },

0 commit comments

Comments
 (0)