Skip to content

Commit deaa7e3

Browse files
committed
update tests to reflect decoupling
Signed-off-by: Itay Dafna <[email protected]>
1 parent c1428de commit deaa7e3

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

tests/test_datagrid.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ def dataframe() -> None:
1515
def datagrid(dataframe) -> None:
1616
return DataGrid(dataframe)
1717

18+
@pytest.fixture
19+
def data_object(dataframe) -> None:
20+
return DataGrid.generate_data_object(dataframe, "ipydguuid")
21+
1822

1923
@pytest.mark.parametrize("clear", [True, False])
2024
def test_selections(clear: bool, dataframe: pd.DataFrame) -> None:
@@ -73,15 +77,15 @@ def test_column_name_to_index(invalid_index: bool, datagrid: DataGrid) -> None:
7377

7478

7579
@pytest.mark.parametrize("invalid_index", [True, False])
76-
def test_column_index_to_name(invalid_index: bool, datagrid: DataGrid) -> None:
80+
def test_column_index_to_name(invalid_index: bool, data_object: dict) -> None:
7781
if invalid_index:
78-
assert datagrid._column_index_to_name(4) is None
82+
assert DataGrid._column_index_to_name(data_object, 4) is None
7983
else:
80-
assert datagrid._column_index_to_name(1) == "B"
84+
assert DataGrid._column_index_to_name(data_object, 1) == "B"
8185

8286

83-
def test_get_col_headers(datagrid) -> None:
84-
assert datagrid._get_col_headers() == ["A", "B"]
87+
def test_get_col_headers(data_object) -> None:
88+
assert DataGrid._get_col_headers(data_object) == ["A", "B"]
8589

8690

8791
@pytest.mark.parametrize("invalid_prim_key", [True, False])
@@ -96,9 +100,9 @@ def test_get_row_index_of_primary_key(
96100

97101
@pytest.mark.parametrize("invalid_coords", [True, False])
98102
def test_get_cell_value_by_numerical_index(
99-
invalid_coords: bool, datagrid: DataGrid
103+
invalid_coords: bool, data_object: dict
100104
) -> None:
101105
if invalid_coords:
102-
assert datagrid._get_cell_value_by_numerical_index(2, 2) is None
106+
assert DataGrid._get_cell_value_by_numerical_index(data_object, 2, 2) is None
103107
else:
104-
assert datagrid._get_cell_value_by_numerical_index(1, 0) == 4
108+
assert DataGrid._get_cell_value_by_numerical_index(data_object, 1, 0) == 4

0 commit comments

Comments
 (0)