Skip to content

Commit 3c7afa2

Browse files
committed
Fix Layer's Popup and typo in Popup class
1 parent 2f27919 commit 3c7afa2

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

js/src/layers/Layer.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
var widgets = require('@jupyter-widgets/base');
22
var _ = require('underscore');
3+
var PMessaging = require('@phosphor/messaging');
4+
var PWidgets = require('@phosphor/widgets');
35
var L = require('../leaflet.js');
46
var utils = require('../utils.js')
57

@@ -91,12 +93,9 @@ var LeafletLayerView = utils.LeafletWidgetView.extend({
9193
var that = this;
9294
this.popup_content_promise = this.popup_content_promise.then(function() {
9395
return that.create_child_view(value).then(function(view) {
96+
PMessaging.MessageLoop.sendMessage(view.pWidget, PWidgets.Widget.Msg.BeforeAttach);
9497
that.obj.bindPopup(view.el, that.popup_options());
95-
96-
// Trigger the displayed event of the child view.
97-
that.displayed.then(function() {
98-
view.trigger('displayed', that);
99-
});
98+
PMessaging.MessageLoop.sendMessage(view.pWidget, PWidgets.Widget.Msg.AfterAttach);
10099

101100
that.popup_content = view;
102101
that.trigger('popup_content:created');

js/src/layers/Popup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ var LeafletPopupView = LeafletUILayerView.extend({
6060
this.child_promise = this.child_promise.then(function() {
6161
return that.create_child_view(value).then(function(view) {
6262
PMessaging.MessageLoop.sendMessage(view.pWidget, PWidgets.Widget.Msg.BeforeAttach);
63-
thar.obj.setContent(view.el);
63+
that.obj.setContent(view.el);
6464
PMessaging.MessageLoop.sendMessage(view.pWidget, PWidgets.Widget.Msg.AfterAttach);
6565
that.force_update();
6666
that.child = view;

0 commit comments

Comments
 (0)