JS linters (#1057)

* JS linters

* Iterate

* Lint

* Update ci

* Fix file name

* Missing dependencies

Author: martinRenou

.github/workflows/main.yml

@@ -28,17 +28,14 @@ jobs:
     - name: Setup conda
       uses: conda-incubator/setup-miniconda@v2
       with:
+        environment-file: environment-dev.yml
+        activate-environment: ipyleaflet-dev
         mamba-version: "*"
+        python-version: ${{ matrix.python-version }}
         channels: conda-forge
 
-    - name: Mamba install dependencies
-      run: mamba install python=${{ matrix.python-version }} pip nodejs flake8
-
-    - name: Mamba install dependencies
-      run: mamba install jupyterlab ipywidgets openssl=1.1.1l jupyter-packaging~=0.7.9
-
     - name: Install ipyleaflet
-      run: pip install .
+      run: pip install . --no-deps
 
     - name: Check installation files
       run: |
@@ -48,8 +45,14 @@ jobs:
         test -d $CONDA_PREFIX/share/jupyter/labextensions/jupyter-leaflet
         test -f $CONDA_PREFIX/share/jupyter/labextensions/jupyter-leaflet/package.json
 
-    - name: Flake8 check
+    - name: Python Linters
       run: flake8 ipyleaflet --ignore=E501,E731
 
+    - name: JS Linters
+      run: |
+        yarn install
+        yarn run lint:check
+      working-directory: js
+
     - name: Import check
       run: python -c 'import ipyleaflet'

.github/workflows/ui-tests.yml

@@ -22,14 +22,14 @@ jobs:
       - name: Setup conda
         uses: conda-incubator/setup-miniconda@v2
         with:
+          environment-file: environment-dev.yml
+          activate-environment: ipyleaflet-dev
           mamba-version: "*"
+          python-version: ${{ matrix.python-version }}
           channels: conda-forge
 
-      - name: Mamba install dependencies
-        run: mamba install python=${{ matrix.python-version }} pip nodejs=16 flake8 jupyterlab ipywidgets>=8.0.1 jupyter-packaging~=0.7.9 pandas
-
       - name: Install ipyleaflet
-        run: pip install .
+        run: pip install . --no-deps
 
       - name: Install browser
         run: |

.github/workflows/update_galata_references.yml

@@ -35,14 +35,14 @@ jobs:
       - name: Setup conda
         uses: conda-incubator/setup-miniconda@v2
         with:
+          environment-file: environment-dev.yml
+          activate-environment: ipyleaflet-dev
           mamba-version: "*"
+          python-version: ${{ matrix.python-version }}
           channels: conda-forge
 
-      - name: Mamba install dependencies
-        run: mamba install python=${{ matrix.python-version }} pip nodejs flake8 jupyterlab ipywidgets pandas jupyter-packaging~=0.7.9
-
       - name: Install ipyleaflet
-        run: pip install .
+        run: pip install . --no-deps
 
       - name: Install JS deps
         run: |

environment-dev.yml

@@ -0,0 +1,14 @@
+name: ipyleaflet-dev
+channels:
+  - conda-forge
+dependencies:
+  - pip
+  - wheel
+  - flake8
+  - jupyterlab
+  - ipywidgets
+  - xyzservices
+  - branca
+  - traittypes
+  - jupyter-packaging~=0.7.9
+  - pandas

js/.eslintignore

@@ -0,0 +1,2 @@
+node_modules
+dist

js/.eslintrc.json

@@ -1,19 +1,20 @@
 {
-    "env": {
-        "browser": true,
-        "es6": true,
-        "node": true
-    },
-    "extends": "eslint:recommended",
-    "globals": {
-        "Atomics": "readonly",
-        "SharedArrayBuffer": "readonly"
-    },
-    "parserOptions": {
-        "ecmaVersion": 11,
-        "sourceType": "module"
-    },
-    "rules": {
-      "object-curly-spacing": ["error", "always"]
-    }
+  "env": {
+    "browser": true,
+    "es6": true,
+    "node": true
+  },
+  "extends": "eslint:recommended",
+  "globals": {
+    "Atomics": "readonly",
+    "SharedArrayBuffer": "readonly",
+    "L": true
+  },
+  "parserOptions": {
+    "ecmaVersion": 11,
+    "sourceType": "module"
+  },
+  "rules": {
+    "object-curly-spacing": ["error", "always"]
+  }
 }

js/.prettierignore

@@ -0,0 +1,2 @@
+node_modules
+dist

js/.prettierrc.json

@@ -0,0 +1,3 @@
+{
+  "singleQuote": true
+}

js/README.md

@@ -1,15 +1,14 @@
-Jupyter Leaflet Widget
-======================
+# Jupyter Leaflet Widget
 
 Interactive leaflet widget for the Jupyter notebook
 
 The reference Python backend, `ipyleaflet` is available
 [here](https://github.com/jupyter-widgets/ipyleaflet), with examples.
 
-Package Install
----------------
+## Package Install
 
 **Prerequisites**
+
 - [node](https://nodejs.org/)
 
 ```bash

js/amd-public-path.js

@@ -2,7 +2,7 @@
 // See https://github.com/requirejs/requirejs/wiki/Differences-between-the-simplified-CommonJS-wrapper-and-standard-AMD-define#module
 // Since 'module' is a requirejs magic module, we must include 'module' in the webpack externals configuration.
 var module = require('module');
-var url = new URL(module.uri, document.location)
+var url = new URL(module.uri, document.location);
 // Using lastIndexOf('/')+1 gives us the empty string if there is no '/', so pathname becomes '/'
-url.pathname = url.pathname.slice(0,url.pathname.lastIndexOf('/')+1);
-__webpack_public_path__ = `${url.origin}${url.pathname}`;
+url.pathname = url.pathname.slice(0, url.pathname.lastIndexOf('/') + 1);
+__webpack_public_path__ = `${url.origin}${url.pathname}`; // eslint-disable-line no-undef