Skip to content

Commit 092e2f7

Browse files
committed
Update docstrings 🧾
1 parent 898fcf1 commit 092e2f7

File tree

3 files changed

+29
-12
lines changed

3 files changed

+29
-12
lines changed

‎packages/controls/src/widget_float.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
BaseIntSliderView,
88
IntRangeSliderView,
99
IntSliderView,
10-
IntTextView,
10+
IntTextView
1111
} from './widget_int';
1212

1313
import { format } from 'd3-format';
@@ -103,7 +103,7 @@ export class FloatLogSliderModel extends BoundedFloatModel {
103103
readout_formatter: any;
104104
}
105105

106-
export class FloatRangeSliderModel extends FloatSliderModel {}
106+
export class FloatRangeSliderModel extends FloatSliderModel { }
107107

108108
export class FloatSliderView extends IntSliderView {
109109
/**
@@ -166,7 +166,8 @@ export class FloatLogSliderView extends BaseIntSliderView {
166166
},
167167
});
168168

169-
// Using noUiSlider's event handler
169+
// Using noUiSlider's 'update' and 'change' events.
170+
// See reference: https://refreshless.com/nouislider/events-callbacks/
170171
this.$slider.noUiSlider.on('update', (values: any, handle: any) => {
171172
this.handleSliderUpdateEvent(values, handle);
172173
});
@@ -222,8 +223,9 @@ export class FloatLogSliderView extends BaseIntSliderView {
222223
}
223224
}
224225
}
226+
225227
/**
226-
* Called when the slider value is changing.
228+
* Called whilst the slider is dragged, tapped or moved by the arrow keys.
227229
*/
228230
handleSliderUpdateEvent(values: number[], handle: number): void {
229231
const base = this.model.get('base');
@@ -237,6 +239,10 @@ export class FloatLogSliderView extends BaseIntSliderView {
237239
}
238240
}
239241

242+
/**
243+
* Called when the slider handle is released after dragging,
244+
* or by tapping or moving by the arrow keys.
245+
*/
240246
handleSliderChangeEvent(values: number[], handle: number): void {
241247
const base = this.model.get('base');
242248
const actual_value = Math.pow(base, this._validate_slide_value(values[0]));

‎packages/controls/src/widget_int.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class IntSliderModel extends BoundedIntModel {
7878
readout_formatter: any;
7979
}
8080

81-
export class IntRangeSliderModel extends IntSliderModel {}
81+
export class IntRangeSliderModel extends IntSliderModel { }
8282

8383
export abstract class BaseIntSliderView extends DescriptionView {
8484
render(): void {
@@ -223,7 +223,8 @@ export abstract class BaseIntSliderView extends DescriptionView {
223223
},
224224
});
225225

226-
// Using noUiSlider's event handler
226+
// Using noUiSlider's 'update' and 'change' events.
227+
// See reference: https://refreshless.com/nouislider/events-callbacks/
227228
this.$slider.noUiSlider.on('update', (values: any, handle: any) => {
228229
this.handleSliderUpdateEvent(values, handle);
229230
});
@@ -268,12 +269,13 @@ export abstract class BaseIntSliderView extends DescriptionView {
268269
abstract handleTextChange(): void;
269270

270271
/**
271-
* Called when the slider value changes on mouseUp.
272+
* Called when the slider handle is released after dragging,
273+
* or by tapping or moving by the arrow keys.
272274
*/
273275
abstract handleSliderChangeEvent(value: any, handle: any): void;
274276

275277
/**
276-
* Called when the slider value changes whilst dragging.
278+
* Called whilst the slider is dragged, tapped or moved by the arrow keys.
277279
*/
278280
abstract handleSliderUpdateEvent(value: any, handle: any): void;
279281

@@ -371,13 +373,20 @@ export class IntRangeSliderView extends BaseIntSliderView {
371373
}
372374
}
373375

376+
/**
377+
* Called when the slider handle is released after dragging,
378+
* or by tapping or moving by the arrow keys.
379+
*/
374380
handleSliderChangeEvent(values: any, handle: any): void {
375381
const actual_value = values.map(this._validate_slide_value);
376382
this.readout.textContent = this.valueToString(actual_value);
377383

378384
this.handleSliderChanged(values, handle);
379385
}
380386

387+
/**
388+
* Called whilst the slider is dragged, tapped or moved by the arrow keys.
389+
*/
381390
handleSliderUpdateEvent(values: any, handle: any): void {
382391
const actual_value = values.map(this._validate_slide_value);
383392
this.readout.textContent = this.valueToString(actual_value);

‎packages/controls/src/widget_selection.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ export class ToggleButtonsView extends DescriptionView {
498498
const previous_icons = this.model.previous('icons') || [];
499499
const previous_bstyle =
500500
(ToggleButtonsView.classMap as any)[
501-
this.model.previous('button_style')
501+
this.model.previous('button_style')
502502
] || '';
503503
const tooltips = this.model.get('tooltips') || [];
504504
const disabled = this.model.get('disabled');
@@ -769,7 +769,8 @@ export class SelectionSliderView extends DescriptionView {
769769
},
770770
});
771771

772-
// Using noUiSlider's event handler
772+
// Using noUiSlider's 'update' and 'change' events.
773+
// See reference: https://refreshless.com/nouislider/events-callbacks/
773774
this.$slider.noUiSlider.on('update', (values: number[], handle: number) => {
774775
this.handleSliderUpdateEvent(values, handle);
775776
});
@@ -797,7 +798,7 @@ export class SelectionSliderView extends DescriptionView {
797798
}
798799

799800
/**
800-
* Called when the slider value changes whilst dragging.
801+
* Called whilst the slider is dragged, tapped or moved by the arrow keys.
801802
*/
802803
handleSliderUpdateEvent(values: number[], handle: number): void {
803804
const index = values[0];
@@ -811,7 +812,8 @@ export class SelectionSliderView extends DescriptionView {
811812
}
812813

813814
/**
814-
* Called on a mouseUp event.
815+
* Called when the slider handle is released after dragging,
816+
* or by tapping or moving by the arrow keys.
815817
*/
816818
handleSliderChangeEvent(values: number[], handle: number): void {
817819
const index = values[0];

0 commit comments

Comments
 (0)