some tests of deprecation

Author: vidartf

python/ipywidgets/ipywidgets/widgets/tests/test_utils.py

@@ -1,4 +1,5 @@
 
+import inspect
 from pathlib import Path
 from unittest.mock import patch
 
@@ -7,6 +8,9 @@
 from ipywidgets.widgets.utils import deprecation
 from ipywidgets.widgets.tests.utils import call_method
 
+
+CALL_PATH = inspect.getfile(call_method)
+
 @patch("ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL", [])
 def test_deprecation_direct():
     with pytest.warns(DeprecationWarning) as record:
@@ -20,9 +24,9 @@ def test_deprecation_indirect():
     with pytest.warns(DeprecationWarning) as record:
         call_method(deprecation, "test message")
     assert len(record) == 1
-    assert Path(record[0].filename) == Path(__file__, '..', 'utils.py').resolve()
+    assert record[0].filename == CALL_PATH
 
-@patch("ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL", [str(Path(__file__, '..', 'utils.py').resolve())])
+@patch("ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL", [CALL_PATH])
 def test_deprecation_indirect_internal():
     # If the line that calls "deprecation" is internal, it is not considered the source:
     with pytest.warns(DeprecationWarning) as record:

python/ipywidgets/ipywidgets/widgets/tests/test_widget_button.py

@@ -0,0 +1,18 @@
+# Copyright (c) Jupyter Development Team.
+# Distributed under the terms of the Modified BSD License.
+
+from unittest.mock import patch
+import pytest
+
+import ipywidgets as widgets
+
+
+@patch(
+    "ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL",
+    ['widgets/widget.py', 'widgets/widget_button.py']
+)
+def test_fa_prefix_deprecation():
+    with pytest.deprecated_call() as record:
+        widgets.Button(icon="fa-gear")
+    assert len(record) == 1
+    assert record[0].filename == __file__

python/ipywidgets/ipywidgets/widgets/tests/test_widget_string.py

@@ -1,7 +1,43 @@
 # Copyright (c) Jupyter Development Team.
 # Distributed under the terms of the Modified BSD License.
 
-from ..widget_string import Combobox
+from ..widget_string import Combobox, Text
+from unittest.mock import patch
+import pytest
+
+
+@patch(
+    "ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL",
+    ['widgets/widget_string.py']
+)
+def test_on_submit_deprecation():
+    w = Text()
+    with pytest.deprecated_call() as record:
+        w.on_submit(lambda: None)
+    assert len(record) == 1
+    assert record[0].filename == __file__
+
+
+@patch(
+    "ipywidgets.widgets.utils._IPYWIDGETS_INTERNAL",
+    ['widgets/widget_string.py', 'widgets/widget_description.py']
+)
+def test_tooltip_deprecation():
+    with pytest.deprecated_call() as record:
+        w = Text(description_tooltip="testing")
+    assert len(record) == 1
+    assert record[0].filename == __file__
+
+    with pytest.deprecated_call() as record:
+        assert w.description_tooltip == "testing"
+    assert len(record) == 1
+    assert record[0].filename == __file__
+
+    with pytest.deprecated_call() as record:
+        w.description_tooltip = "second value"
+    assert len(record) == 1
+    assert record[0].filename == __file__
+    assert w.tooltip == "second value"
 
 
 def test_combobox_creation_blank():