Merge branch 'borders3' of github.com:zerline/ipywidgets into borders3

Author: Zerline

.github/workflows/lint.yml

@@ -3,7 +3,8 @@ name: Lint
 on: [push, pull_request]
 
 jobs:
-  build:
+  lint:
+    name: Lint
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/testdocs.yml

@@ -0,0 +1,131 @@
+name: Test
+
+on: [push, pull_request]
+
+jobs:
+  docs:
+    name: Documentation
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python
+      uses: actions/setup-python@v1
+      with:
+        python-version: 3.7
+    - uses: actions/cache@v1
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}-${{hashFiles('**/requirements.txt')}}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Install dependencies
+      run: |
+        sudo apt-get install -y pandoc
+        python -m pip install --upgrade pip
+        pip install file://$PWD#egg=ipywidgets
+        pip install -r ./docs/requirements.txt
+    - name: Build docs
+      run: |
+        cd docs
+        make html
+  js:
+    name: JavaScript
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Use Node.js 10.x
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10.x
+    - name: Install dependencies
+      run: |
+        sudo apt-get install -y firefox
+    - name: Get yarn cache
+      id: yarn-cache
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+    - uses: actions/cache@v1
+      with:
+        path: ${{ steps.yarn-cache.outputs.dir }}
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+    - name: yarn install, build, test
+      run: |
+        yarn install --frozen-lockfile
+        yarn run build
+        yarn run build:examples
+
+        pushd packages/base
+        yarn run test:unit:firefox:headless
+        popd
+
+        pushd packages/base-manager
+        yarn run test:unit:firefox:headless
+        popd
+
+        pushd packages/controls
+        yarn run test:unit:firefox:headless
+        popd
+
+        pushd packages/html-manager
+        yarn run test:unit:firefox:headless
+        popd
+
+        pushd examples/web1
+        yarn run test:firefox:headless
+        popd
+
+      env:
+        CI: true
+  python:
+    name: Python
+    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.5, 3.6, 3.7, 3.8]
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - uses: actions/cache@v1
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}-${{hashFiles('**/requirements.txt')}}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install file://$PWD#egg=ipywidgets[test]
+    - name: Test with pytest
+      run: |
+        pip install pytest
+        pytest --cov=ipywidgets ipywidgets
+  spec:
+    name: Message Specification
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python
+      uses: actions/setup-python@v1
+      with:
+        python-version: 3.5
+    - uses: actions/cache@v1
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}-${{hashFiles('**/requirements.txt')}}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install file://$PWD#egg=ipywidgets
+    - name: Compare spec with latest version
+      run: |
+        python ./packages/schema/generate-spec.py -f markdown > spec.md
+        diff -u ./packages/schema/jupyterwidgetmodels.latest.md ./spec.md

.github/workflows/testjs.yml

@@ -10,15 +10,16 @@
 from .widget_box import Box
 from .widget import register
 from .widget_core import CoreWidget
-from traitlets import Unicode, Dict, CInt, TraitError, validate
+from traitlets import Unicode, Dict, CInt, TraitError, validate, observe
 
 
 class _SelectionContainer(Box, CoreWidget):
     """Base class used to display multiple child widgets."""
     _titles = Dict(help="Titles of the pages").tag(sync=True)
     selected_index = CInt(
         help="""The index of the selected page. This is either an integer selecting a particular sub-widget, or None to have no widgets selected.""",
-        allow_none=True
+        allow_none=True,
+        default_value=None
     ).tag(sync=True)
 
     @validate('selected_index')
@@ -28,6 +29,11 @@ def _validated_index(self, proposal):
         else:
             raise TraitError('Invalid selection: index out of bounds')
 
+    @observe('children')
+    def _observe_children(self, change):
+        if self.selected_index is not None and len(change.new) < self.selected_index:
+            self.selected_index = None
+
     # Public methods
     def set_title(self, index, title):
         """Sets the title of a container page.
@@ -79,6 +85,10 @@ class Tab(_SelectionContainer):
     _view_name = Unicode('TabView').tag(sync=True)
     _model_name = Unicode('TabModel').tag(sync=True)
 
+    def __init__(self, **kwargs):
+        if 'children' in kwargs and 'selected_index' not in kwargs and len(kwargs['children']) > 0:
+            kwargs['selected_index'] = 0
+        super(Tab, self).__init__(**kwargs)
 
 @register
 class Stacked(_SelectionContainer):

.github/workflows/testpython.yml

@@ -31,7 +31,7 @@ export class SelectionContainerModel extends BoxModel {
     return {
       ...super.defaults(),
       _model_name: 'SelectionContainerModel',
-      selected_index: 0,
+      selected_index: null,
       _titles: {}
     };
   }