Merge pull request #2984 from maartenbreddels/fix_missing_return_in_cdn_fallback

SylvainCorlay · web-flow · commit 51322341d4f6 · 2020-09-29T15:37:35.000+02:00
fix: when CDN is used as fallback, no module is returned
diff --git a/packages/html-manager/src/libembed-amd.ts b/packages/html-manager/src/libembed-amd.ts
@@ -85,7 +85,7 @@ export function requireLoader(
     if (failedId) {
       require.undef(failedId);
       console.log(`Falling back to ${cdn} for ${moduleName}@${moduleVersion}`);
-      loadFromCDN();
+      return loadFromCDN();
     }
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ export function requireLoader(`
`85`	`85`	`if (failedId) {`
`86`	`86`	`require.undef(failedId);`
`87`	`87`	console.log(`Falling back to ${cdn} for ${moduleName}@${moduleVersion}`);
`88`		`- loadFromCDN();`
	`88`	`+ return loadFromCDN();`
`89`	`89`	`}`
`90`	`90`	`});`
`91`	`91`	`}`