Skip to content

Commit 5a2ca50

Browse files
committed
Avoid unnecessary definition of intermediate models
1 parent 85548ab commit 5a2ca50

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

packages/controls/src/widget_upload.ts

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,11 @@ export class FileUploadView extends DOMWidgetView {
5959

6060
this.fileInput.addEventListener('change', () => {
6161
const promisesFile: Promise<{
62-
buffer: any;
63-
metadata: any;
62+
content: any;
63+
name: string;
64+
size: number;
65+
type: string;
66+
lastModified: number;
6467
error: string;
6568
}>[] = [];
6669

@@ -75,10 +78,10 @@ export class FileUploadView extends DOMWidgetView {
7578
};
7679
const fileReader = new FileReader();
7780
fileReader.onload = (event): any => {
78-
const buffer = (event as any).target.result;
81+
const content = (event as any).target.result;
7982
resolve({
80-
buffer,
81-
metadata,
83+
content,
84+
...metadata,
8285
error: ''
8386
});
8487
};
@@ -92,15 +95,9 @@ export class FileUploadView extends DOMWidgetView {
9295
});
9396

9497
Promise.all(promisesFile)
95-
.then(contents => {
96-
const value = contents.map(c => {
97-
return {
98-
...c.metadata,
99-
content: c.buffer
100-
};
101-
});
98+
.then(files => {
10299
this.model.set({
103-
value,
100+
value: files,
104101
error: ''
105102
});
106103
this.touch();

0 commit comments

Comments
 (0)