Skip to content

Commit bf68169

Browse files
committed
Deserialize state before setting it, as is done elsewhere set_state is used.
This is causing at least one problem in the ipyleaflet 8.0 upgrade tests, as seen in jupyter-widgets/ipyleaflet#968
1 parent 3e6e99d commit bf68169

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/base-manager/src/manager-base.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,10 @@ export abstract class ManagerBase implements IWidgetManager {
487487
} else {
488488
// model already exists here
489489
const model = await this.get_model(widget_id);
490-
model!.set_state(state.state);
490+
const deserializedState = await (
491+
model.constructor as typeof WidgetModel
492+
)._deserialize_state(state.state, this);
493+
model!.set_state(deserializedState);
491494
}
492495
} catch (error) {
493496
// Failed to create a widget model, we continue creating other models so that

0 commit comments

Comments
 (0)