Skip to content

Commit c5103e4

Browse files
authored
Merge pull request #3625 from martinRenou/soften_manager_requirement
WidgetRenderer: Soften manager type requirement
2 parents 31ee8c8 + 5d9f503 commit c5103e4

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

python/jupyterlab_widgets/src/renderer.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Panel, Widget as LuminoWidget } from '@lumino/widgets';
99

1010
import { IRenderMime } from '@jupyterlab/rendermime-interfaces';
1111

12-
import { WidgetManager } from './manager';
12+
import { LabWidgetManager } from './manager';
1313
import { DOMWidgetModel } from '@jupyter-widgets/base';
1414

1515
/**
@@ -19,7 +19,10 @@ export class WidgetRenderer
1919
extends Panel
2020
implements IRenderMime.IRenderer, IDisposable
2121
{
22-
constructor(options: IRenderMime.IRendererOptions, manager?: WidgetManager) {
22+
constructor(
23+
options: IRenderMime.IRendererOptions,
24+
manager?: LabWidgetManager
25+
) {
2326
super();
2427
this.mimeType = options.mimeType;
2528
if (manager) {
@@ -30,7 +33,7 @@ export class WidgetRenderer
3033
/**
3134
* The widget manager.
3235
*/
33-
set manager(value: WidgetManager) {
36+
set manager(value: LabWidgetManager) {
3437
value.restored.connect(this._rerender, this);
3538
this._manager.resolve(value);
3639
}
@@ -117,6 +120,6 @@ export class WidgetRenderer
117120
* The mimetype being rendered.
118121
*/
119122
readonly mimeType: string;
120-
private _manager = new PromiseDelegate<WidgetManager>();
123+
private _manager = new PromiseDelegate<LabWidgetManager>();
121124
private _rerenderMimeModel: IRenderMime.IMimeModel | null = null;
122125
}

0 commit comments

Comments
 (0)