Skip to content

Dynamic widgets registry #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 3 commits into from
May 5, 2025
Merged

Dynamic widgets registry #3988

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d67fc4d
Dynamic widgets registry
martinRenou Apr 29, 2025
d983904
Linter
martinRenou Apr 29, 2025
910868e
Rename registeredWidget -> widgetRegistered
martinRenou May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions python/jupyterlab_widgets/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,31 @@ import '@jupyter-widgets/controls/css/widgets-base.css';
import { KernelMessage } from '@jupyterlab/services';
import { ITranslator, nullTranslator } from '@jupyterlab/translation';
import { ISessionContext } from '@jupyterlab/apputils';
import { ISignal, Signal } from '@lumino/signaling';

const WIDGET_REGISTRY: base.IWidgetRegistryData[] = [];
class WidgetRegistry {
get widgets(): base.IWidgetRegistryData[] {
return [...this._registry];
}

push(data: base.IWidgetRegistryData) {
this._registry.push(data);
this._registeredWidget.emit(data);
}

get registeredWidget(): ISignal<WidgetRegistry, base.IWidgetRegistryData> {
return this._registeredWidget;
}

private _registeredWidget = new Signal<
WidgetRegistry,
base.IWidgetRegistryData
>(this);

private _registry: base.IWidgetRegistryData[] = [];
}

const WIDGET_REGISTRY = new WidgetRegistry();

/**
* The cached settings.
Expand Down Expand Up @@ -178,7 +201,10 @@ async function registerWidgetHandler(

if (!wManager) {
wManager = widgetManagerFactory();
WIDGET_REGISTRY.forEach((data) => wManager!.register(data));
WIDGET_REGISTRY.widgets.forEach((data) => wManager!.register(data));
WIDGET_REGISTRY.registeredWidget.connect((_, data) => {
wManager!.register(data);
});
Private.widgetManagerProperty.set(wManagerOwner, wManager);
currentOwner = wManagerOwner;
content.disposed.connect((_) => {
Expand Down Expand Up @@ -241,7 +267,10 @@ export function registerWidgetManager(
) as WidgetManager;
if (!currentManager) {
wManager = new WidgetManager(context, rendermime, SETTINGS);
WIDGET_REGISTRY.forEach((data) => wManager!.register(data));
WIDGET_REGISTRY.widgets.forEach((data) => wManager!.register(data));
WIDGET_REGISTRY.registeredWidget.connect((_, data) => {
wManager!.register(data);
});
Private.widgetManagerProperty.set(wManagerOwner, wManager);
} else {
wManager = currentManager;
Expand Down
Loading