Skip to content

Commit 21a8e47

Browse files
committed
Merge stragglers
1 parent cff51c9 commit 21a8e47

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

jslab/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"license": "BSD-3-Clause",
1111
"dependencies": {
1212
"@jupyter-widgets/jupyterlab-manager": "^0.23.2",
13-
"jupyter-threejs": "^0.3.0-alpha.0"
13+
"jupyter-threejs": "^0.4.0-alpha.0"
1414
},
1515
"jupyterlab": {
1616
"extension": true

pythreejs/_base/Three.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22
from traitlets import Unicode, CInt, Bool, Instance
33
from .._package import npm_pkg_name
44

5+
from .._version import EXTENSION_VERSION
6+
57

68
class RenderableWidget(DOMWidget):
79
_view_module = Unicode(npm_pkg_name).tag(sync=True)
810
_model_module = Unicode(npm_pkg_name).tag(sync=True)
11+
_view_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
12+
_model_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
913

1014
# renderer properties
1115
_width = CInt(200).tag(sync=True)
@@ -36,6 +40,7 @@ def freeze(self):
3640

3741
class ThreeWidget(Widget):
3842
_model_module = Unicode(npm_pkg_name).tag(sync=True)
43+
_model_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
3944

4045
def __init__(self, **kwargs):
4146
super(ThreeWidget, self).__init__(**kwargs)

pythreejs/pythreejs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
from ._package import npm_pkg_name
2222
from .enums import Shading, Colors
23+
from ._version import EXTENSION_VERSION
2324

2425

2526
from .core.Object3D import Object3D
@@ -48,7 +49,6 @@ def vector2(trait_type=CFloat, default=None, **kwargs):
4849
default = [0, 0]
4950
return List(trait_type, default_value=default, minlen=2, maxlen=2, **kwargs)
5051

51-
PYTHREEJS_VERSION='0.4.0-alpha.0'
5252

5353
class ScaledObject(Object3D):
5454
"""
@@ -212,8 +212,8 @@ def flatten(ll):
212212
class Effect(Widget):
213213
_view_module = Unicode(npm_pkg_name).tag(sync=True)
214214
_model_module = Unicode(npm_pkg_name).tag(sync=True)
215-
_model_module_version = Unicode(PYTHREEJS_VERSION).tag(sync=True)
216-
_view_module_version = Unicode(PYTHREEJS_VERSION).tag(sync=True)
215+
_model_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
216+
_view_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
217217

218218

219219
class AnaglyphEffect(Effect):

0 commit comments

Comments
 (0)