Skip to content

Commit 253fbc0

Browse files
committed
Update log statements for easier filtering
1 parent 89c67ba commit 253fbc0

File tree

5 files changed

+25
-22
lines changed

5 files changed

+25
-22
lines changed

js/src/_base/Preview.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ var PreviewView = RenderableView.extend({
5858

5959
if (obj.isObject3D) {
6060

61-
this.log('render Object3D');
61+
this.debug('render Object3D');
6262
// Use a clone to not change `parent` attribute
6363
this.scene.add(obj.clone());
6464

@@ -161,7 +161,7 @@ var PreviewView = RenderableView.extend({
161161

162162
setupControls: function() {
163163
// Allow user to inspect object with mouse/scrollwheel
164-
this.log('setting up controls');
164+
this.debug('setting up controls');
165165
var control = new OrbitControls(this.camera, this.renderer.domElement);
166166
control.target.set(0, 0, 0);
167167
control.update();
@@ -195,7 +195,7 @@ var PreviewView = RenderableView.extend({
195195
},
196196

197197
renderScene: function() {
198-
this.log('renderScene');
198+
this.debug('renderScene');
199199

200200
if (this.isFrozen) {
201201
this.unfreeze();

js/src/_base/Renderable.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var RenderableModel = widgets.DOMWidgetModel.extend({
8383
},
8484

8585
onChildChanged: function(model, options) {
86-
console.log('child changed: ' + model.model_id);
86+
console.debug('child changed: ' + model.model_id);
8787
// Let listeners (e.g. views) know:
8888
this.trigger('childchange', this);
8989
},
@@ -238,7 +238,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
238238
},
239239

240240
renderScene: function(scene, camera) {
241-
this.log('renderScene');
241+
this.debug('renderScene');
242242

243243
scene = scene || this.scene;
244244
camera = camera || this.camera;
@@ -266,7 +266,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
266266
if (!this.isFrozen) {
267267
return;
268268
}
269-
this.log('unfreeze');
269+
this.debug('unfreeze');
270270

271271
this.isFrozen = false;
272272

@@ -284,7 +284,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
284284

285285
acquireRenderer: function() {
286286

287-
this.log('ThreeView.acquiring...');
287+
this.debug('ThreeView.acquiring...');
288288

289289
var config = {
290290
antialias: this.model.get('_antialias'),
@@ -300,7 +300,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
300300

301301
this.updateSize();
302302

303-
this.log('ThreeView.acquireRenderer(' + this.renderer.poolId + ')');
303+
this.debug('ThreeView.acquireRenderer(' + this.renderer.poolId + ')');
304304
},
305305

306306
freeze: function() {
@@ -309,7 +309,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
309309
return;
310310
}
311311

312-
this.log('ThreeView.freeze(id=' + this.renderer.poolId + ')');
312+
this.debug('ThreeView.freeze(id=' + this.renderer.poolId + ')');
313313

314314
this.$el.empty().append('<img src="' + this.renderer.domElement.toDataURL() + '" />');
315315

@@ -321,7 +321,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
321321

322322
if (this.controls) {
323323
this.$frozenRenderer.on('mouseenter', _.bind(function() {
324-
this.log('frozenRenderer.mouseenter');
324+
this.debug('frozenRenderer.mouseenter');
325325
this.tick(); // renderer will be acquired by renderScene
326326
}, this));
327327
}
@@ -348,7 +348,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
348348
},
349349

350350
enableControls: function() {
351-
this.log('Enable controls');
351+
this.debug('Enable controls');
352352
var that = this;
353353
this.controls.forEach(function(control) {
354354
control.enabled = true;
@@ -358,7 +358,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
358358
},
359359

360360
disableControls: function() {
361-
this.log('Disable controls');
361+
this.debug('Disable controls');
362362
var that = this;
363363
this.controls.forEach(function(control) {
364364
control.enabled = false;
@@ -377,7 +377,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
377377
},
378378

379379
onRendererReclaimed: function() {
380-
this.log('ThreeView WebGL context is being reclaimed: ' + this.renderer.poolId);
380+
this.debug('ThreeView WebGL context is being reclaimed: ' + this.renderer.poolId);
381381

382382
this.freeze();
383383
},
@@ -386,6 +386,10 @@ var RenderableView = widgets.DOMWidgetView.extend({
386386
console.log('TV(' + this.id + '): ' + str);
387387
},
388388

389+
debug: function(str) {
390+
console.debug('TV(' + this.id + '): ' + str);
391+
},
392+
389393
lazyRendererSetup: function() {
390394
throw new Error('RenderableView should not be used directly, please subclass!');
391395
}

js/src/_base/RendererPool.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ _.extend(RendererPool.prototype, {
9292
acquire: function(config, onReclaim) {
9393

9494
var renderer;
95-
console.log('RendererPool.acquiring...');
95+
console.debug('RendererPool.acquiring...');
9696

9797
if (this.freePool.length > 0) {
9898

@@ -131,14 +131,14 @@ _.extend(RendererPool.prototype, {
131131

132132
// Ensure aliasing state matches, or remake
133133

134-
console.log('RendererPool.acquire(id=' + renderer.poolId + ')');
134+
console.debug('RendererPool.acquire(id=' + renderer.poolId + ')');
135135
this.claimedPool.push(config, makeRendererClaimToken(renderer, onReclaim));
136136
renderer.clear();
137137
return renderer;
138138
},
139139

140140
release: function(renderer) {
141-
console.log('RendererPool.release(id=' + renderer.poolId + ')');
141+
console.debug('RendererPool.release(id=' + renderer.poolId + ')');
142142

143143
var id = renderer.poolId;
144144
var kvPair = this.claimedPool.popFind(function(claimToken) {

js/src/_base/Three.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,12 @@ var ThreeModel = widgets.WidgetModel.extend({
235235
console.log('SERVER: ' + JSON.stringify(content.msg));
236236
break;
237237
default:
238-
console.log('ERROR: invalid custom message');
239-
console.log(content);
238+
console.error('ERROR: invalid custom message', content);
240239
}
241240
},
242241

243242
onExecThreeObjMethod: function(methodName, args, buffers) {
244-
console.log('execThreeObjMethod: ' + methodName +
243+
console.debug('execThreeObjMethod: ' + methodName +
245244
'(' + args.map(JSON.stringify).join(',') + ')');
246245

247246
if (!(methodName in this.obj)) {
@@ -292,7 +291,7 @@ var ThreeModel = widgets.WidgetModel.extend({
292291
retVal = retVal.ipymodel;
293292
}
294293

295-
console.log('sending return value to server...');
294+
console.debug('sending return value to server...');
296295
this.send({
297296
type: 'exec_three_obj_method_retval',
298297
method_name: methodName,
@@ -317,7 +316,7 @@ var ThreeModel = widgets.WidgetModel.extend({
317316
},
318317

319318
onChildChanged: function(model) {
320-
console.log('child changed: ' + model.model_id);
319+
console.debug('child changed: ' + model.model_id);
321320
// Propagate up hierarchy:
322321
this.trigger('childchange', this);
323322
},

js/src/textures/ImageTexture.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var ImageTextureModel = ImageTextureBase.ImageTextureModel.extend({
1616
return resolve(texture);
1717
},
1818
function(xhr) {
19-
console.log(imageUri + ': ' + (xhr.loaded / xhr.total * 100) + '%');
19+
console.debug(imageUri + ': ' + (xhr.loaded / xhr.total * 100) + '%');
2020
},
2121
function(xhr) {
2222
console.log('Error loading texture: ' + imageUri);

0 commit comments

Comments
 (0)