Fix index attribute on BufferGeometry

Ensure it gets set also if set from reference

Author: vidartf

js/scripts/three-class-config.js

@@ -371,6 +371,7 @@ module.exports = {
         relativePath: './core/BufferGeometry',
         superClass: 'BaseBufferGeometry',
         properties: {
+            index:              new Types.ThreeType(['BufferAttribute', 'InterleavedBufferAttribute']),
             attributes:         new Types.ThreeTypeDict(['BufferAttribute', 'InterleavedBufferAttribute']),
             morphAttributes:    new Types.BufferMorphAttributes(),
             MaxIndex:           new Types.Int(65535),

js/src/core/BufferGeometry.js

@@ -35,7 +35,12 @@ var BufferGeometryModel = AutogenBufferGeometryModel.extend({
                 Promise.all(_.map(_.values(ref.get('morphAttributes')), function(attr) {
                     return attr.initPromise;
                 }))
-            );
+            ).then(function() {
+                // Wait for index attribute
+                return ref.get('index').then(function(index) {
+                    return index.initPromise;
+                });
+            });
         }
 
         // Create three.js BufferAttributes from ref.
@@ -80,6 +85,15 @@ var BufferGeometryModel = AutogenBufferGeometryModel.extend({
         }).then(function(attribModelKVs) {
             toSet.morphAttributes = _.object(attribModelKVs);
 
+        // Then create models for index attribute:
+        }).then(function() {
+            if (result.index) {
+                var modelCtor = result.index.isInterleavedBufferAttribute ? InterleavedBufferAttributeModel : BufferAttributeModel;
+                return createModel(modelCtor, this.widget_manager, result.index).then(function(model) {
+                    toSet.index = model;
+                }, this);
+            }
+
         // Sync out all properties that have been set:
         }).then(function() {
             // Add other fields that needs to be synced out:

pythreejs/core/BufferGeometry.py

@@ -35,11 +35,14 @@ def validate(self, proposal):
     def _gen_repr_from_keys(self, keys):
         # Hide data in repr to avoid overly large datasets
         # Replace with uuids of buffer attributes
+        data_keys = ('attributes', 'morphAttributes', 'index')
         class_name = self.__class__.__name__
         signature_parts = [
             '%s=%r' % (key, getattr(self, key))
-            for key in keys if key not in ('attributes', 'morphAttributes')
+            for key in keys if key not in data_keys
         ]
+        if not self._compare(self.index, self.__class__.index.default_value):
+            signature_parts.append('index=%s' % _attr_value_repr(self.index))
         for name in ('attributes', 'morphAttributes'):
             if not _dict_is_default(self, name):
                 signature_parts.append('%s=%s' % (name, _attr_dict_repr(getattr(self, name))))