Change how previewability is determined

Author: vidartf

pythreejs/_base/Three.py

@@ -11,6 +11,8 @@ class ThreeWidget(Widget):
     _model_module = Unicode(npm_pkg_name).tag(sync=True)
     _model_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
 
+    _previewable = True
+
     def __init__(self, **kwargs):
         super(ThreeWidget, self).__init__(**kwargs)
         self.on_msg(self._on_potential_ret_val)
@@ -38,6 +40,9 @@ def _on_ret_val(self, method_name, ret_val):
         self.log.info('%s() -> %s' % (method_name, ret_val))
 
     def _ipython_display_(self, **kwargs):
-        from IPython.display import display
-        from .renderable import Preview
-        return display(Preview(self), **kwargs)
+        if self._previewable:
+            from IPython.display import display
+            from .renderable import Preview
+            return display(Preview(self), **kwargs)
+        else:
+            return super(ThreeWidget, self)._ipython_display_(**kwargs)

pythreejs/animation/AnimationAction.py

@@ -18,9 +18,7 @@ class AnimationAction(AnimationActionBase, DOMWidget):
     _view_module = Unicode(npm_pkg_name).tag(sync=True)
     _view_module_version = Unicode(EXTENSION_VERSION).tag(sync=True)
 
+    _previewable = False
+
     # Normally an int, but can also be inf:
     repititions = Union([CInt(), CFloat()], default_value=float('inf'), allow_none=False).tag(sync=True)
-
-    # Override default super MRO resolution (this is a mixin):
-    def _ipython_display_(self, **kwargs):
-        return Widget._ipython_display_(self, **kwargs)

pythreejs/core/BufferAttribute.py

@@ -7,6 +7,8 @@
 @register
 class BufferAttribute(BaseBufferAttribute):
 
+    _previewable = False
+
     def __init__(self, array=None, normalized=True, **kwargs):
         if array is not None:
             # Only include array in kwargs if supplied
@@ -16,12 +18,3 @@ def __init__(self, array=None, normalized=True, **kwargs):
         kwargs['normalized'] = normalized
         # NOTE: skip init of direct parent class on purpose:
         super(BaseBufferAttribute, self).__init__(**kwargs)
-
-    def _ipython_display_(self, **kwargs):
-        # Preview widget doesn't make any sense for attributes
-        from IPython.display import display
-        data = {
-            'text/plain': repr(self),
-        }
-        display(data, raw=True)
-        self._handle_displayed(**kwargs)