Skip to content

Commit 5506fe9

Browse files
committed
Ensure renderer props are always applied
All renderers need to set their properties when acquiring.
1 parent eb5e8ea commit 5506fe9

File tree

3 files changed

+4
-16
lines changed

3 files changed

+4
-16
lines changed

js/src/_base/Renderable.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,10 @@ class RenderableView extends widgets.DOMWidgetView {
427427

428428
this.updateSize();
429429

430+
// We need to ensure that renderer properties are applied
431+
// (we have no idea where the renderer has been...)
432+
this.updateProperties(true);
433+
430434
this.debug('ThreeView.acquireRenderer(' + this.renderer.poolId + ')');
431435
}
432436

js/src/core/Renderer.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -166,14 +166,6 @@ class RendererView extends RenderableView {
166166
}
167167
}
168168

169-
acquireRenderer() {
170-
RenderableView.prototype.acquireRenderer.call(this);
171-
172-
// We need to ensure that renderer properties are applied
173-
// (we have no idea where the renderer has been...)
174-
this.updateProperties(true);
175-
}
176-
177169
}
178170

179171
module.exports = {

js/src/renderers/WebGLRenderer.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,6 @@ class WebGLRendererView extends RenderableView {
5555
console.log('WGLR(' + this.id + '): ' + str);
5656
}
5757

58-
acquireRenderer() {
59-
RenderableView.prototype.acquireRenderer.call(this);
60-
61-
// We need to ensure that renderer properties are applied
62-
// (we have no idea where the renderer has been...)
63-
this.updateProperties();
64-
}
65-
6658
//
6759
// Handlers
6860
//

0 commit comments

Comments
 (0)