Skip to content

Commit 771e32e

Browse files
committed
Add some informative comments
1 parent 805e256 commit 771e32e

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

js/scripts/generate-wrappers.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -223,22 +223,22 @@ function mapPromiseFnOverThreeModules(mapFn) {
223223
cwd: threeSrcDir,
224224
nodir: true ,
225225
ignore: [
226-
'**/Three.Legacy.js',
227-
'**/polyfills.js',
228-
'**/utils.js',
229-
'**/constants.js',
230-
'**/animation/KeyframeTrackConstructor.js',
231-
'**/animation/KeyframeTrackPrototype.js',
232-
'**/audio/AudioContext.js',
233-
'**/geometries/Geometries.js',
234-
'**/materials/Materials.js',
235-
'**/renderers/WebGLRenderer.js',
236-
'**/renderers/WebGL2Renderer.js',
226+
'**/Three.Legacy.js', // Don't support legacy interface (deprecation should be done python side)
227+
'**/polyfills.js', // Polyfill of JS methods, nothing to export
228+
'**/utils.js', // Utility functions, no objects to export
229+
'**/constants.js', // Processed into enums in separate script
230+
'**/animation/KeyframeTrackConstructor.js', // Sub-part of one object, ignore
231+
'**/animation/KeyframeTrackPrototype.js', // Sub-part of one object, ignore
232+
'**/audio/AudioContext.js', // JS API for audio, nothing to expose
233+
'**/geometries/Geometries.js', // index.js like file, nothing new here
234+
'**/materials/Materials.js', // index.js like file, nothing new here
235+
'**/renderers/WebGLRenderer.js', // For now, the internals of the webgl
236+
'**/renderers/WebGL2Renderer.js', // render is not exposed.
237237
'**/renderers/webgl/**',
238238
'**/renderers/shaders/**',
239-
'**/extras/core/Interpolations.js',
240-
'**/extras/core/PathPrototype.js',
241-
'**/textures/CanvasTexture.js'
239+
'**/extras/core/Interpolations.js', // Only functions, nothing to export
240+
'**/extras/core/PathPrototype.js', // Sub-part of one object, ignore
241+
'**/textures/CanvasTexture.js' // Canvases are not referenceable from python
242242
],
243243
});
244244
}

js/src/controls/Picker.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ var PickerAutogen = require('./Picker.autogen');
44

55
var PickerModel = PickerAutogen.PickerModel.extend({});
66

7+
8+
// TODO: Reimplement picker to work with updated model/view separation!
9+
710
/*
811
var PickerView = PickerAutogen.PickerView.extend({
912
render: function() {

0 commit comments

Comments
 (0)