Skip to content

Commit 89f7edf

Browse files
committed
Fix default nullable value
1 parent 4866115 commit 89f7edf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

js/scripts/prop-types.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function ThreeType(typeName, options={}) {
2626
this.typeName = typeName;
2727
this.defaultValue = null;
2828
this.serialize = true;
29-
this.nullable = bool(options.nullable);
29+
this.nullable = options.nullable !== false;
3030
}
3131
_.extend(ThreeType.prototype, BaseType.prototype, {
3232
getTraitlet: function() {
@@ -367,12 +367,12 @@ _.extend(Matrix3.prototype, BaseType.prototype, {
367367

368368
function Matrix4() {
369369
this.defaultValue = [
370-
1, 0, 0, 0,
371-
0, 1, 0, 0,
372-
0, 0, 1, 0,
373-
0, 0, 0, 1
370+
1, 0, 0, 0,
371+
0, 1, 0, 0,
372+
0, 0, 1, 0,
373+
0, 0, 0, 1
374374
];
375-
}
375+
}
376376
_.extend(Matrix4.prototype, BaseType.prototype, {
377377
getTraitlet: function() {
378378
return 'Matrix4(default=' + JSON.stringify(this.defaultValue) + ').tag(sync=True)';

0 commit comments

Comments
 (0)