Skip to content

Commit a39a779

Browse files
committed
Clean up createModel util
1 parent b21ddc1 commit a39a779

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

js/src/_base/utils.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -213,11 +213,13 @@ function createModel(constructor, widget_manager, obj) {
213213
delete widget_manager._models[id];
214214
});
215215

216-
var data, buffers;
217216
widget_manager._models[id] = widget_model.initPromise.then(() => {
217+
// Create un-opened comm:
218+
return widget_manager._create_comm(widget_manager.comm_target_name, id);
219+
}).then(comm => {
218220
var split = widgets.remove_buffers(
219221
widget_model.serialize(widget_model.get_state(true)));
220-
data = {
222+
var data = {
221223
state: _.extend({}, split.state, {
222224
_model_name: constructor.model_name,
223225
_model_module: constructor.model_module,
@@ -228,12 +230,8 @@ function createModel(constructor, widget_manager, obj) {
228230
}),
229231
buffer_paths: split.buffer_paths
230232
};
231-
buffers = split.buffers;
233+
var buffers = split.buffers;
232234

233-
// Create un-opened comm:
234-
return widget_manager._create_comm(widget_manager.comm_target_name, id);
235-
236-
}).then(comm => {
237235
var content = {
238236
'comm_id': id,
239237
'target_name': widget_manager.comm_target_name,

0 commit comments

Comments
 (0)