Lint ES5

Author: vidartf

js/.eslintrc.js

@@ -0,0 +1,27 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "commonjs": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "indent": [
+            "error",
+            4
+        ],
+        "linebreak-style": [
+            "error",
+            "windows"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ],
+        "no-console": "off",
+        "no-unused-vars": "warn",
+    }
+};

js/scripts/templates/js_enums.mustache

@@ -7,7 +7,7 @@
 
 var {{ category.key }} = {
 {{#each category.enums as |enum|}}
-    {{ enum.value }}: "{{ enum.key }}",
+    {{ enum.value }}: '{{ enum.key }}',
 {{/each}}
 };
 {{/each}}

js/src/_base/Preview.js

@@ -1,14 +1,12 @@
 var _ = require('underscore');
-var widgets = require("@jupyter-widgets/base");
-var Promise = require('bluebird');
-var $ = require('jquery');
+var widgets = require('@jupyter-widgets/base');
 
 var THREE = require('three');
 
 var Renderable = require('./Renderable');
 var RenderableView = Renderable.RenderableView;
 var RenderableModel = Renderable.RenderableModel;
-var OrbitControls = require("../examples/controls/OrbitControls.js").OrbitControls;
+var OrbitControls = require('../examples/controls/OrbitControls.js').OrbitControls;
 var utils = require('./utils.js');
 
 
@@ -56,6 +54,8 @@ var PreviewView = RenderableView.extend({
 
         this.clearScene();
 
+        var geometry, mesh;
+
         if (obj.isObject3D) {
 
             this.log('render Object3D');
@@ -85,7 +85,7 @@ var PreviewView = RenderableView.extend({
                 material.vertexColors = THREE.VertexColors;
             }
 
-            var mesh = new THREE.Mesh(obj, material);
+            mesh = new THREE.Mesh(obj, material);
             this.scene.add(mesh);
 
         } else if (obj.isMaterial) {
@@ -101,21 +101,21 @@ var PreviewView = RenderableView.extend({
                 }
                 this.scene.add(sprite);
             } else {
-                var geometry = new THREE.SphereGeometry(15, 16, 12);
-                var mesh = new THREE.Mesh(geometry, obj);
+                geometry = new THREE.SphereGeometry(15, 16, 12);
+                mesh = new THREE.Mesh(geometry, obj);
                 this.scene.add(mesh);
             }
 
         } else if (obj.isTexture) {
 
-            var geometry = new THREE.SphereGeometry(15, 16, 12);
+            geometry = new THREE.SphereGeometry(15, 16, 12);
             var mat = new THREE.MeshStandardMaterial({ map: obj });
-            var mesh = new THREE.Mesh(geometry, mat);
+            mesh = new THREE.Mesh(geometry, mat);
             this.scene.add(mesh);
 
         } else {
 
-            console.log("Unexpected object in preview, scene will be empty:", obj);
+            console.log('Unexpected object in preview, scene will be empty:', obj);
 
         }
 
@@ -135,7 +135,7 @@ var PreviewView = RenderableView.extend({
 
     resetCamera: function() {
         // Compute bounding sphere for entire scene
-        const sphere = utils.computeBoundingSphere(this.scene);
+        var sphere = utils.computeBoundingSphere(this.scene);
         if (sphere === null) {
             sphere = new THREE.Sphere(new THREE.Vector3(), 1);
         }
@@ -144,13 +144,13 @@ var PreviewView = RenderableView.extend({
         utils.lookAtSphere(this.camera, sphere.center, sphere.radius);
 
         // Update controls with new target
-        const control = this.controls[0];
+        var control = this.controls[0];
         control.target.copy(sphere.center);
         control.target0.copy(sphere.center);
         control.update();
 
         // Position light up to the left and behind camera
-        const dist = 2.5 * (this.camera.position.z - sphere.center.z);
+        var dist = 2.5 * (this.camera.position.z - sphere.center.z);
         this.pointLight.position.set(-dist, dist, dist);
     },
 

js/src/_base/Renderable.js

@@ -1,5 +1,5 @@
 var _ = require('underscore');
-var widgets = require("@jupyter-widgets/base");
+var widgets = require('@jupyter-widgets/base');
 var Promise = require('bluebird');
 var $ = require('jquery');
 
@@ -121,7 +121,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
     },
 
     doRender: function() {
-        this.el.className = "jupyter-widget jupyter-threejs";
+        this.el.className = 'jupyter-widget jupyter-threejs';
 
         this.unfreeze();
 
@@ -176,11 +176,12 @@ var RenderableView = widgets.DOMWidgetView.extend({
                 this.renderer[propName] = this.model.get(propName);
                 return;
             }
+            var converterFn;
             if (converterName === 'convertThreeTypeArray') {
-                var converterFn = this[converterName].bind(this);
+                converterFn = this[converterName].bind(this);
             } else {
-                converterName = converterName + "ModelToThree";
-                var converterFn = ThreeModel.prototype[converterName];
+                converterName = converterName + 'ModelToThree';
+                converterFn = ThreeModel.prototype[converterName];
             }
 
             if (!converterFn) {
@@ -211,11 +212,12 @@ var RenderableView = widgets.DOMWidgetView.extend({
                 changes = true;
                 return;
             }
+            var converterFn;
             if (converterName === 'convertThreeTypeArray') {
-                var converterFn = this[converterName].bind(this);
+                converterFn = this[converterName].bind(this);
             } else {
-                converterName = converterName + "ModelToThree";
-                var converterFn = ThreeModel.prototype[converterName];
+                converterName = converterName + 'ModelToThree';
+                converterFn = ThreeModel.prototype[converterName];
             }
 
             if (!converterFn) {
@@ -367,10 +369,10 @@ var RenderableView = widgets.DOMWidgetView.extend({
 
     onCustomMessage: function(content, buffers) {
         switch(content.type) {
-            case 'freeze':
-                this.freeze();
-                break;
-            default:
+        case 'freeze':
+            this.freeze();
+            break;
+        default:
         }
     },
 

js/src/_base/RendererPool.js

@@ -72,9 +72,9 @@ _.extend(RendererPool.prototype, {
                     // required for converting canvas to png
                     preserveDrawingBuffer: true
                 }
-        ));
+            ));
         renderer.setPixelRatio(window.devicePixelRatio || 1);
-        renderer.context.canvas.addEventListener("webglcontextlost", this.onContextLost.bind(this), false);
+        renderer.context.canvas.addEventListener('webglcontextlost', this.onContextLost.bind(this), false);
         renderer.poolId = this.numCreated;
         this.numCreated++;
         return renderer;