enable flat shading control for default geometry rendering

Author: abelnation

examples/Geometries.ipynb

@@ -2,7 +2,7 @@
  "cells": [
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 1,
    "metadata": {
     "collapsed": true
    },
@@ -117,14 +117,13 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 2,
    "metadata": {
     "collapsed": false
    },
    "outputs": [],
    "source": [
-    "# TODO: flat shading\n",
-    "DodecahedronGeometry(radius=10, detail=0)"
+    "DodecahedronGeometry(radius=10, detail=0, _flat=True)"
    ]
   },
   {
@@ -153,14 +152,13 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 3,
    "metadata": {
     "collapsed": true
    },
    "outputs": [],
    "source": [
-    "# TODO: flat shading\n",
-    "IcosahedronGeometry(radius=10)"
+    "IcosahedronGeometry(radius=10, _flat=True)"
    ]
   },
   {
@@ -186,18 +184,18 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 4,
    "metadata": {
     "collapsed": true
    },
    "outputs": [],
    "source": [
-    "OctahedronGeometry(radius=10, detail=0)"
+    "OctahedronGeometry(radius=10, detail=0, _flat=True)"
    ]
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 5,
    "metadata": {
     "collapsed": true
    },
@@ -210,7 +208,7 @@
     "        return new THREE.Vector3(10 * x, 10 * y, x*x - y*y); \n",
     "    }\"\"\",\n",
     "    slices=5,\n",
-    "    stacks=10)"
+    "    stacks=10, _flat=True)"
    ]
   },
   {
@@ -225,7 +223,7 @@
     "    width=10,\n",
     "    height=15,\n",
     "    widthSegments=5,\n",
-    "    heightSegments=10,)"
+    "    heightSegments=10)"
    ]
   },
   {
@@ -240,7 +238,7 @@
     "    width=10,\n",
     "    height=15,\n",
     "    widthSegments=5,\n",
-    "    heightSegments=10,)"
+    "    heightSegments=10)"
    ]
   },
   {
@@ -341,14 +339,13 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 6,
    "metadata": {
     "collapsed": true
    },
    "outputs": [],
    "source": [
-    "# TODO: flat shading\n",
-    "TetrahedronGeometry(radius=10, detail=1)"
+    "TetrahedronGeometry(radius=10, detail=1, _flat=True)"
    ]
   },
   {
@@ -483,6 +480,46 @@
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython2",
    "version": "2.7.12"
+  },
+  "widgets": {
+   "state": {
+    "345bb19e86e8492ab984784d5e28b4ea": {
+     "views": [
+      {
+       "cell_index": 10
+      }
+     ]
+    },
+    "91929632315b4de9a9dbc9820e74c5bc": {
+     "views": [
+      {
+       "cell_index": 12
+      }
+     ]
+    },
+    "97beb4476542488885d834cf97285479": {
+     "views": [
+      {
+       "cell_index": 13
+      }
+     ]
+    },
+    "edf315d5a75b42b2909bb96c91e7654a": {
+     "views": [
+      {
+       "cell_index": 22
+      }
+     ]
+    },
+    "fa3df762942744dbbda986a316f570ef": {
+     "views": [
+      {
+       "cell_index": 7
+      }
+     ]
+    }
+   },
+   "version": "1.2.0"
   }
  },
  "nbformat": 4,

js/src/_base/Three.js

@@ -112,9 +112,17 @@ var ThreeView = widgets.DOMWidgetView.extend({
 
         } else if (obj instanceof THREE.Geometry || obj instanceof THREE.BufferGeometry) {
 
-            var material = new THREE.MeshStandardMaterial({
-                color: '#888888',
-            });
+            var material;
+            if (this.model.get('_flat')) {
+                material = new THREE.MeshPhongMaterial({
+                    color: '#888888',
+                    shading: THREE.FlatShading,
+                });
+            } else {
+                material = new THREE.MeshStandardMaterial({
+                    color: '#888888',
+                });
+            }
             var mesh = new THREE.Mesh(obj, material);
             this.scene.add(mesh);
 
@@ -285,6 +293,7 @@ var ThreeModel = widgets.DOMWidgetModel.extend({
 
         _width: 200,
         _height: 200,
+        _flat: false,
     }),
 
     initialize: function(attributes, options) {

pythreejs/_base/Three.py

@@ -10,6 +10,7 @@ class ThreeWidget(Widget):
     # renderer properties
     _width = CInt(200).tag(sync=True)
     _height = CInt(200).tag(sync=True)
+    _flat = Bool(False).tag(sync=True)
 
     def __init__(self, **kwargs):
         Widget.__init__(self, **kwargs)