Skip to content

Commit b96b333

Browse files
committed
Fix setting BufferGeometry index attribute
1 parent 939c9bf commit b96b333

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

js/src/geometries/PlainBufferGeometry.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ var createModel = require('../_base/utils').createModel;
33

44
var AutogenPlainBufferGeometryModel = require('../geometries/PlainBufferGeometry.autogen').PlainBufferGeometryModel;
55

6-
var core = require('../core')
7-
var BufferGeometryModel = core.BufferGeometryModel;
8-
var BufferAttributeModel = core.BufferAttributeModel;
9-
var GeometryModel = core.GeometryModel;
6+
var BufferAttributeModel = require('../core/BufferAttribute.js').BufferAttributeModel;
7+
var GeometryModel = require('../core/Geometry.autogen.js').GeometryModel;
8+
var BufferGeometryModel = require('../core/BufferGeometry.autogen.js').BufferGeometryModel;
109

1110

1211
var PlainBufferGeometryModel = AutogenPlainBufferGeometryModel.extend({
@@ -111,7 +110,11 @@ var PlainBufferGeometryModel = AutogenPlainBufferGeometryModel.extend({
111110
console.warn('Cannot remove buffer geometry attributes:', removed);
112111
}
113112
added.forEach(key => {
114-
obj.addAttribute(key, value[key]);
113+
if (key === 'index') {
114+
obj.setIndex(value[key]);
115+
} else {
116+
obj.addAttribute(key, value[key]);
117+
}
115118
});
116119

117120
var commonChanged = _.filter(common, key => { return obj.getAttribute(key) !== value[key]});

0 commit comments

Comments
 (0)