Skip to content

Commit be9dd21

Browse files
committed
Clean up material properties
1 parent ed05ce6 commit be9dd21

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

js/scripts/three-class-config.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -501,19 +501,19 @@ module.exports = {
501501
properties: {
502502
alphaTest: new Types.Float(0.0),
503503
blendDst: new Types.Enum('BlendFactors', 'OneMinusSrcAlphaFactor'),
504-
//blendDstAlpha: new Types.Float(null),
504+
blendDstAlpha: new Types.Float(null),
505505
blending: new Types.Enum('BlendingMode', 'NormalBlending'),
506506
blendSrc: new Types.Enum('BlendFactors', 'SrcAlphaFactor'),
507-
//blendSrcAlpha: new Types.Float(null),
507+
blendSrcAlpha: new Types.Float(null),
508508
blendEquation: new Types.Enum('Equations', 'AddEquation'),
509-
//blendEquationAlpha: new Types.Float(null),
509+
blendEquationAlpha: new Types.Float(null),
510510
clipIntersection: new Types.Bool(false),
511-
//clippingPlanes: new Types.ThreeTypeArray('Plane'), // TODO: Should default to null
511+
clippingPlanes: new Types.ThreeTypeArray('Plane'),
512512
clipShadows: new Types.Bool(false),
513513
colorWrite: new Types.Bool(true),
514514
//customDepthMaterial: new Types.ForwardDeclaredThreeType('MeshDepthMaterial', 'pythreejs', {allowNull: true}),
515515
//customDistanceMaterial: new Types.ForwardDeclaredThreeType('MeshDepthMaterial', 'pythreejs', {allowNull: true}),
516-
//defines: new Types.Dict(undefined),
516+
defines: new Types.Dict(null, true),
517517
depthFunc: new Types.Enum('DepthMode', 'LessEqualDepth'),
518518
depthTest: new Types.Bool(true),
519519
depthWrite: new Types.Bool(true),
@@ -524,7 +524,7 @@ module.exports = {
524524
polygonOffset: new Types.Bool(false),
525525
polygonOffsetFactor: new Types.Float(0),
526526
polygonOffsetUnits: new Types.Float(0),
527-
//precision: new Types.String('lowp'), // TODO: Needs to be undefined on JS side!
527+
precision: new Types.String(null, true),
528528
premultipliedAlpha: new Types.Bool(false),
529529
dithering: new Types.Bool(false),
530530
shading: new Types.Enum('Shading', 'SmoothShading'),
@@ -747,13 +747,12 @@ module.exports = {
747747
morphTargets: new Types.Bool(false),
748748
shading: new Types.Enum('Shading', 'SmoothShading'),
749749
skinning: new Types.Bool(false),
750-
uniforms: new Types.Dict(),
751750
vertexShader: new Types.String(''),
752751
wireframe: new Types.Bool(false),
753752
wireframeLinewidth: new Types.Float(1.0),
754753
},
755754
constructorArgs: [ 'parameters' ],
756-
propsDefinedByThree: [ 'extenstions' ],
755+
propsDefinedByThree: [ 'extensions' ],
757756
},
758757
ShadowMaterial: {
759758
relativePath: './materials/ShadowMaterial',

0 commit comments

Comments
 (0)