Skip to content

Commit d91e676

Browse files
authored
Merge pull request #156 from vidartf/fixed
Various fixes
2 parents 0ee2ca3 + 7fc3f3f commit d91e676

11 files changed

+24
-9
lines changed

js/package.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,15 @@
3535
"three": "^0.88.0",
3636
"underscore": "^1.8.3"
3737
},
38+
"keywords": [
39+
"jupyterlab",
40+
"extension",
41+
"jupyterlab extension",
42+
"notebook",
43+
"jupyter",
44+
"widgets",
45+
"three"
46+
],
3847
"jupyterlab": {
3948
"extension": "src/jupyterlab-plugin"
4049
}

js/scripts/copy-files.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const docStaticDir = path.resolve(baseDir, '..', 'docs', 'source', '_static');
1515

1616
function copyThree() {
1717
return fse.copy(
18-
path.resolve(threeBuildDir, 'three.min.js'),
18+
path.resolve(threeBuildDir, 'three.js'),
1919
path.resolve(staticDir, 'three.js')
2020
).then(function() {
2121
console.log('Copied three.js to static folder');
@@ -33,7 +33,7 @@ function copyBundleToDocs() {
3333

3434
function copyThreeToDocs() {
3535
return fse.copy(
36-
path.resolve(threeBuildDir, 'three.min.js'),
36+
path.resolve(threeBuildDir, 'three.js'),
3737
path.resolve(docStaticDir, 'three.js')
3838
).then(function() {
3939
console.log('Copied three.js to docs folder');

js/scripts/templates/js_enums.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//
22
// This file auto-generated with {{ generatorScriptName }}
3-
// Date: {{ now }}
43
//
54

65
{{#each categories as |category|}}

js/scripts/templates/js_index.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//
22
// This file auto-generated with {{ generatorScriptName }}
3-
// Date: {{ now }}
43
//
54
{{#if top_level}}
65

js/scripts/templates/js_wrapper.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//
22
// This file auto-generated with {{ generatorScriptName }}
3-
// Date: {{ now }}
43
//
54

65
var _ = require('underscore');

js/scripts/templates/py_enums.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"""
22
This file auto-generated with {{ generatorScriptName }}
3-
Date: {{ now }}
43
"""
54

65
class EnumNamespace:

js/scripts/templates/py_shader_utils.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
"""{{ name }}
22

33
Autogenerated by {{ generatorScriptName }}
4-
Date: {{ now }}
54
"""
65

76
import json

js/scripts/templates/py_top_level_init.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#
22
# This file automatically generated by {{ generateScriptName }}
3-
# Date: {{ now }}
43
#
54

65
from __future__ import absolute_import

js/scripts/templates/py_wrapper.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class {{ className }}({{ superClass.className }}):
2222
"""{{ className }}
2323

2424
Autogenerated by {{ generatorScriptName }}
25-
Date: {{ now }}
2625
{{#if isCustom}}
2726
This class is a custom class for pythreejs, with no
2827
direct corresponding class in three.js.

js/scripts/three-class-config.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,9 @@ module.exports = {
101101
CubeCamera: {
102102
relativePath: './cameras/CubeCamera',
103103
superClass: 'Object3D',
104+
properties: {
105+
type: new Types.String('CubeCamera'),
106+
}
104107
},
105108
OrthographicCamera: {
106109
relativePath: './cameras/OrthographicCamera',
@@ -113,6 +116,7 @@ module.exports = {
113116
bottom: new Types.Float(),
114117
near: new Types.Float(0.1),
115118
far: new Types.Float(2000),
119+
type: new Types.String('OrthographicCamera'),
116120
},
117121
constructorArgs: [ 'left', 'right', 'top', 'bottom', 'near', 'far' ],
118122
},
@@ -129,13 +133,15 @@ module.exports = {
129133
// view: new Types.Dict(),
130134
// filmGauge: new Types.Float(35.0),
131135
// filmOffset: new Types.Float(0.0),
136+
type: new Types.String('PerspectiveCamera'),
132137
},
133138
constructorArgs: [ 'fov', 'aspect', 'near', 'far' ],
134139
},
135140
ArrayCamera: {
136141
relativePath: './cameras/ArrayCamera',
137142
superClass: 'PerspectiveCamera',
138143
properties: {
144+
type: new Types.String('ArrayCamera'),
139145
},
140146
constructorArgs: [ 'fov', 'aspect', 'near', 'far' ],
141147
},
@@ -341,6 +347,7 @@ module.exports = {
341347
attributes: new Types.ThreeTypeDict(['BufferAttribute', 'InterleavedBufferAttribute']),
342348
morphAttributes: new Types.BufferMorphAttributes(),
343349
MaxIndex: new Types.Int(65535),
350+
type: new Types.String('BufferGeometry'),
344351
// TODO: These likely require special types:
345352
//groups: new Types.GeometryGroup(),
346353
//drawRange: new Types.DrawRange(),
@@ -668,6 +675,7 @@ module.exports = {
668675
refractionRatio: new Types.Float(0.98),
669676
skinning: new Types.Bool(false),
670677
specularMap: new Types.ThreeType('Texture'),
678+
type: new Types.String('MeshBasicMaterial'),
671679
wireframe: new Types.Bool(false),
672680
wireframeLinewidth: new Types.Float(1),
673681
wireframeLinecap: new Types.String('round'), // TODO: enum?
@@ -1036,6 +1044,7 @@ module.exports = {
10361044
geometry: new Types.ThreeType(['BaseGeometry', 'BaseBufferGeometry'], {nullable: false}),
10371045
drawMode: new Types.Enum('DrawModes', 'TrianglesDrawMode'),
10381046
morphTargetInfluences: new Types.Array(),
1047+
type: new Types.String('Mesh'),
10391048
},
10401049
propsDefinedByThree: ['morphTargetInfluences'],
10411050
},
@@ -1673,6 +1682,7 @@ module.exports = {
16731682
hex: new Types.Int(0),
16741683
headLength: new Types.Float(null, {nullable: true}),
16751684
headWidth: new Types.Float(null, {nullable: true}),
1685+
type: new Types.String('ArrowHelper'),
16761686
},
16771687
},
16781688
AxesHelper: {

0 commit comments

Comments
 (0)