Skip to content

Commit f283a13

Browse files
committed
Remove unused view names
Further highlight that most three widgets are models only.
1 parent 2b43170 commit f283a13

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

js/scripts/generate-class-config.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var outPath = path.resolve(scriptDir, 'three-class-config.js');
1818
function generateClassConfig() {
1919

2020
return new Promise(function(resolve, reject) {
21-
21+
2222
var lines = [
2323
"//",
2424
"// base version of this file auto-generated by " + path.basename(__filename),
@@ -40,10 +40,8 @@ function generateClassConfig() {
4040
" " + className.replace(/\./g, '_') + ": {",
4141
" relativePath: './" + path.join(classDir, className) + "',",
4242
// " modelName: '" + className + "Model',",
43-
// " viewName: '" + className + "View',",
4443
// " superDepModuleName: 'base',",
4544
// " superDepModulePath: './base',",
46-
// " viewSuperClass: 'ThreeView',",
4745
// " modelSuperClass: 'ThreeModel',",
4846
// " properties: {},",
4947
// " constructorArgs: [],",
@@ -65,7 +63,7 @@ function generateClassConfig() {
6563
.on('abort', function() {
6664
reject(new Error('Aborted'));
6765
});
68-
66+
6967
});
7068

7169
}

js/scripts/generate-wrappers.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ function JavascriptWrapper(modulePath, className) {
292292
this.config = getClassConfig(this.className);
293293

294294
this.modelName = this.className + 'Model';
295-
this.viewName = this.className + 'View';
296295

297296
// check if manual file exists
298297
var customSrcPath = path.join(path.dirname(this.jsDestPath), path.basename(this.jsDestPath, '.js') + '.js');
@@ -351,7 +350,6 @@ _.extend(JavascriptWrapper.prototype, {
351350
}
352351

353352
result.modelName = result.className + 'Model';
354-
result.viewName = result.className + 'View';
355353

356354
result.absolutePath = path.resolve(jsSrcDir, result.relativePath);
357355
var absPath = result.absolutePath;
@@ -477,12 +475,10 @@ _.extend(JavascriptWrapper.prototype, {
477475

478476
var overrideModule = "Override";
479477
var overrideModel = overrideModule + "." + this.modelClass;
480-
var overrideView = overrideModule + "." + this.viewClass;
481478

482479
this.overrideClass = {
483480
relativePath: './' + this.className + '.js',
484481
modelName: overrideModel,
485-
viewName: overrideView,
486482
};
487483

488484
},
@@ -679,7 +675,6 @@ function PythonWrapper(modulePath, className) {
679675
},
680676

681677
className: this.className,
682-
viewName: this.className + 'View',
683678
modelName: this.className + 'Model',
684679
superClass: this.superClass,
685680
properties: this.properties,

js/scripts/templates/py_wrapper.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ class {{ className }}({{ superClass.className }}):
3131
super({{ className }}, self).__init__(**kwargs)
3232

3333
{{/unless}}
34-
_view_name = Unicode('{{ viewName }}').tag(sync=True)
3534
_model_name = Unicode('{{ modelName }}').tag(sync=True)
3635

3736
{{#each properties as |prop propName|}}

0 commit comments

Comments
 (0)