Skip to content

Commit 8f3e364

Browse files
committed
Use the python package name for the nbextension files
Some npm package names have the form @org/packagename, which does not work so well on a filesystem, and besides, it is probably easier for the user to understand if the nbextension name matches the python package name.
1 parent e357e3f commit 8f3e364

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

tests/testconfig.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ default_context:
44
github_project_name: "jupyter-widget-testwidgets"
55
github_organization_name: "jupyter"
66
python_package_name: "ipywidgettestwidgets"
7-
npm_package_name: "jupyter-widget-testwidgets"
7+
npm_package_name: "@jupyter-widgets/jupyter-widget-testwidgets"
88
npm_package_version: "1.1.0"
99
project_short_description: "A Test Jupyter Widget Library"

{{cookiecutter.github_project_name}}/setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
}
4545

4646
data_files_spec = [
47-
('share/jupyter/nbextensions/{{ cookiecutter.npm_package_name }}',
47+
('share/jupyter/nbextensions/{{ cookiecutter.python_package_name}}',
4848
nb_path, '*.js*'),
4949
('share/jupyter/lab/extensions', lab_path, '*.tgz'),
50-
('etc/jupyter/nbconfig/notebook.d' , HERE, '{{ cookiecutter.npm_package_name }}.json')
50+
('etc/jupyter/nbconfig/notebook.d' , HERE, '{{ cookiecutter.python_package_name}}.json')
5151
]
5252

5353

{{cookiecutter.github_project_name}}/{{cookiecutter.npm_package_name}}.json

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"load_extensions": {
3+
"{{ cookiecutter.python_package_name}}/extension": true
4+
}
5+
}

0 commit comments

Comments
 (0)