Merge pull request #36 from vidartf/fix-webpack

Fix webpack public path

Author: vidartf

{{cookiecutter.github_project_name}}/package.json

@@ -53,6 +53,7 @@
     "@types/expect.js": "^0.3.29",
     "@types/mocha": "^5.2.5",
     "@types/node": "^10.11.6",
+    "@types/webpack-env": "^1.13.6",
     "expect.js": "^0.3.1",
     "fs-extra": "^7.0.0",
     "karma": "^3.0.0",

{{cookiecutter.github_project_name}}/src/extension.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Jupyter Development Team.
+// Distributed under the terms of the Modified BSD License.
+
+// Entry point for the notebook bundle containing custom model definitions.
+//
+// Setup notebook base URL
+//
+// Some static assets may be required by the custom widget javascript. The base
+// url for the notebook is not known at build time and is therefore computed
+// dynamically.
+__webpack_public_path__ = document.querySelector('body')!.getAttribute('data-base-url') + 'nbextensions/{{ cookiecutter.npm_package_name }}';
+
+export * from './index';

{{cookiecutter.github_project_name}}/tests/karma.conf.js

@@ -11,7 +11,10 @@ module.exports = function (config) {
     },
     files: [
       { pattern: "tests/src/**/*.ts" },
-      { pattern: "src/**/*.ts" }
+      { pattern: "src/**/*.ts" },
+    ],
+    exclude: [
+      "src/extension.ts",
     ],
     preprocessors: {
       '**/*.ts': ['karma-typescript']

{{cookiecutter.github_project_name}}/webpack.config.js

@@ -6,35 +6,38 @@ const rules = [
 
 // Packages that shouldn't be bundled but loaded at runtime
 const externals = ['@jupyter-widgets/base', 'three', 'jupyter-threejs'];
-var version = require('./package.json').version;
-var path = require('path');
+const version = require('./package.json').version;
+const path = require('path');
+
+
+const resolve = {
+  // Add '.ts' and '.tsx' as resolvable extensions.
+  extensions: [".webpack.js", ".web.js", ".ts", ".js"]
+};
 
 module.exports = [
   {
     // Notebook extension
-    entry: './src/index.ts',
+    entry: './src/extension.ts',
     output: {
       filename: 'index.js',
-      path: __dirname + '/{{ cookiecutter.python_package_name }}/nbextension/static',
+      path: path.resolve(__dirname, '{{ cookiecutter.python_package_name }}', 'nbextension', 'static'),
       libraryTarget: 'amd'
     },
     module: {
       rules: rules
     },
     devtool: 'source-map',
     externals: ['@jupyter-widgets/base'],
-    resolve: {
-      // Add '.ts' and '.tsx' as resolvable extensions.
-      extensions: [".webpack.js", ".web.js", ".ts", ".js"]
-    }
+    resolve,
   },
 
   {
     // embeddable bundle (e.g. for docs)
     entry: './src/index.ts',
     output: {
       filename: 'embed-bundle.js',
-      path: __dirname + '/docs/source/_static',
+      path: path.resolve(__dirname, 'docs', 'source', '_static'),
       library: "{{ cookiecutter.npm_package_name }}",
       libraryTarget: 'amd'
     },
@@ -43,10 +46,7 @@ module.exports = [
     },
     devtool: 'source-map',
     externals: ['@jupyter-widgets/base'],
-    resolve: {
-      // Add '.ts' and '.tsx' as resolvable extensions.
-      extensions: [".webpack.js", ".web.js", ".ts", ".js"]
-    },
+    resolve,
   },
   {// Embeddable {{ cookiecutter.npm_package_name }} bundle
     //
@@ -75,9 +75,6 @@ module.exports = [
         rules: rules
     },
     externals: ['@jupyter-widgets/base'],
-    resolve: {
-      // Add '.ts' and '.tsx' as resolvable extensions.
-      extensions: [".webpack.js", ".web.js", ".ts", ".js"]
-    },
+    resolve,
   }
 ];

{{cookiecutter.github_project_name}}/{{cookiecutter.python_package_name}}/nbextension/static/extension.js

@@ -1,13 +1,3 @@
-// Entry point for the notebook bundle containing custom model definitions.
-//
-// Setup notebook base URL
-//
-// Some static assets may be required by the custom widget javascript. The base
-// url for the notebook is not known at build time and is therefore computed
-// dynamically.
-__webpack_public_path__ = document.querySelector('body').getAttribute('data-base-url') + 'nbextensions/{{ cookiecutter.npm_package_name }}';
-
-
 define(function() {
     "use strict";