Skip to content

Commit 56a0a15

Browse files
authored
Merge pull request #14 from jupyter-xeus/data_view_draft_UNCOMPILED
data_view_draft_UNCOMPILED
2 parents b1c9e1f + 835df97 commit 56a0a15

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/xembind.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,13 @@ namespace xeus
4343
ems::val js_array_buffer = js_array["buffer"].as<ems::val>();
4444
ems::val byteOffset = js_array["byteOffset"].as<ems::val>();
4545
const unsigned length = js_array["length"].as<unsigned> ();
46-
const unsigned bytes_per_element = js_array["BYTES_PER_ELEMENT"].as<unsigned>();
47-
const unsigned length_uint8 = length * bytes_per_element;
48-
46+
const unsigned length_uint8 = js_array["byteLength"].as<unsigned>();
47+
4948
// convert js typed-array into an Uint8Array
5049
ems::val js_uint8array = ems::val::global("Uint8Array").new_(
5150
js_array_buffer,
5251
byteOffset,
53-
length * bytes_per_element
52+
length_uint8
5453
);
5554

5655
// resize array on c++ size

0 commit comments

Comments
 (0)