Skip to content

Commit f406d5d

Browse files
committed
Fix JupyterLite deployment
1 parent f8974fc commit f406d5d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ jobs:
5454
-DCMAKE_INSTALL_PREFIX="$PREFIX" \
5555
-DCMAKE_FIND_ROOT_PATH="$PREFIX" \
5656
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
57+
-DXEUS_OCTAVE_PKG_REBUILD=ON \
5758
-DCMAKE_VERBOSE_MAKEFILE=ON
5859
5960
emmake make -j${{ env.ncpus }} install
@@ -65,6 +66,8 @@ jobs:
6566
--XeusAddon.prefix=${{ env.PREFIX }} \
6667
--XeusAddon.mounts=$PREFIX/share/octave:/share/octave \
6768
--XeusAddon.mounts=$PREFIX/share/xeus-octave:/share/xeus-octave \
69+
--XeusAddon.default_channels=https://repo.prefix.dev/emscripten-forge-dev \
70+
--XeusAddon.default_channels=https://repo.prefix.dev/conda-forge \
6871
--contents notebooks/xeus-octave-wasm.ipynb \
6972
--output-dir dist
7073

src/xinterpreter.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,8 @@ void xoctave_interpreter::configure_impl()
440440
#ifdef XEUS_OCTAVE_PKG_REBUILD
441441
// Run pkg rebuild upon starting the kernel
442442
std::string pkg_rebuild("pkg rebuild");
443-
m_octave_interpreter.eval_string(pkg_rebuild);
443+
int status = 0;
444+
m_octave_interpreter.eval_string(pkg_rebuild, true, status);
444445
#endif
445446

446447
// Fix disp function and clear display function

0 commit comments

Comments
 (0)