Skip to content

Commit d6d0f25

Browse files
committed
bring back comment and add version
1 parent 92441ba commit d6d0f25

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/xinterpreter.cpp

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,16 @@ namespace xpyt
270270

271271
nl::json interpreter::kernel_info_request_impl()
272272
{
273+
274+
/* The jupyter-console banner for xeus-python is the following:
275+
__ _____ _ _ ___
276+
\ \/ / _ \ | | / __|
277+
> < __/ |_| \__ \
278+
/_/\_\___|\__,_|___/
279+
280+
xeus-python: a Jupyter kernel for Python
281+
*/
282+
273283
std::string banner = ""
274284
" __ _____ _ _ ___\n"
275285
" \\ \\/ / _ \\ | | / __|\n"
@@ -294,7 +304,7 @@ namespace xpyt
294304
});
295305

296306
return xeus::create_info_reply(
297-
"", // protocol_version
307+
"5.3", // protocol_version
298308
"xeus-python", // implementation
299309
XPYT_VERSION, // implementation_version
300310
"python", // language_name

src/xinterpreter_raw.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ namespace xpyt
312312
});
313313

314314
return xeus::create_info_reply(
315-
"", // protocol_version
315+
"5.3", // protocol_version
316316
"xeus-python", // implementation
317317
XPYT_VERSION, // implementation_version
318318
"python", // language_name

0 commit comments

Comments
 (0)