Fixed silent mode in raw interpreter #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Sep 12, 2025
|
|
||
| namespace | ||
| { | ||
| class splinter_cell |
JohanMabille
force-pushed
the
silent
branch
from
e114b6b to
f0ed248
Compare
Member
Author
|
The failures are unrelated to the changes. @martinRenou do you want to give it a try on your side to check if this does not break anything? |
Member
|
How do you test this "silent mode"? |
Member
Author
|
I just hardcode it in the execute_impl method :/ Honestly, I don't know which frontend sends execute_request sith silent set to true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.