Skip to content

Commit fc542da

Browse files
committed
Fix some minor issues in docs
1 parent 955ee9f commit fc542da

File tree

11 files changed

+24
-24
lines changed

11 files changed

+24
-24
lines changed

docs/contributing/features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ If there's agreement that the feature belongs in one or more of the core stacks:
5353
make build/<somestack>
5454
```
5555

56-
3. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request)(PR) with your changes.
56+
3. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request) (PR) with your changes.
5757
4. Watch for GitHub to report a build success or failure for your PR on GitHub.
5858
5. Discuss changes with the maintainers and address any build issues.

docs/contributing/issues.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Project Issues
22

3-
We appreciate your taking the time to report an issue you encountered using the Jupyter Docker Stacks.
3+
We appreciate you taking the time to report an issue you encountered while using the Jupyter Docker Stacks.
44
Please review the following guidelines when reporting your problem.
55

66
- If you believe you've found a security vulnerability in any of the Jupyter projects included in Jupyter Docker Stacks images,

docs/contributing/lint.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ pre-commit install
2727
### Run
2828

2929
Now, _pre-commit_ (and so configured hooks) will run automatically on `git commit` on each changed file.
30-
However, it is also possible to trigger it against all files.
30+
However, you can also run it against all files manually.
3131

3232
```{note}
33-
Hadolint pre-commit uses Docker to run, so `docker` should be running while running this command.
33+
Hadolint pre-commit uses Docker to run, so `docker` should be running while executing this command.
3434
```
3535

3636
```sh
@@ -58,7 +58,7 @@ The following rules are ignored by default for all images in the `.hadolint.yaml
5858
- [`DL3008`][dl3008]: System packages are always updated (`apt-get`) to the latest version.
5959
- [`DL3013`][dl3013]: We always install the latest packages using `pip`
6060

61-
The preferred way to do it for other rules is to flag ignored ones in the `Dockerfile`.
61+
The preferred way to ignore other rules is to flag them in the `Dockerfile`.
6262

6363
> It is also possible to ignore rules by using a special comment directly above the Dockerfile instruction you want to make an exception for.
6464
> Ignore rule comments look like `# hadolint ignore=DL3001,SC1081`.

docs/contributing/packages.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ We pin major.minor version of Python, so this will stay the same even after invo
1212
## Outdated packages
1313

1414
To help identify packages that can be updated, you can use the following helper tool.
15-
It will list all the outdated packages installed in the `Dockerfile` --
16-
dependencies are filtered to focus only on requested packages.
15+
It will list all the outdated packages installed in the `Dockerfile`.
16+
Dependencies are filtered to display only the requested packages.
1717

1818
```bash
1919
make check-outdated/base-notebook

docs/contributing/recipes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# New Recipes
22

3-
We welcome contributions of [recipes](../using/recipes.md), and short examples of using, configuring, or extending the Docker Stacks for inclusion in the documentation site.
3+
We welcome contributions of [recipes](../using/recipes.md), which are short examples of using, configuring, or extending the Docker Stacks for inclusion in the documentation site.
44
Follow the process below to add a new recipe:
55

66
1. Open the `docs/using/recipes.md` source file.

docs/contributing/stacks.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ This will serve as both the git repository name and the part of the Docker image
3535
stack_name [my-jupyter-stack]:
3636
```
3737

38-
Enter the user or organization name under which this stack will reside on Quay.io.
39-
You must have access to manage this Quay.io organization to push images here.
38+
Enter the user or organization name under which this stack will reside on Docker Hub.
39+
You must have access to manage this Docker Hub organization to push images here.
4040

4141
```text
4242
stack_org [my-project]:
@@ -150,5 +150,5 @@ Finally, if you'd like to add a link to your project to this documentation site,
150150
1. Fork the [jupyter/docker-stacks](https://github.com/jupyter/docker-stacks) GitHub repository.
151151
2. Open the `docs/using/selecting.md` source file and locate the **Community Stacks** section in your fork.
152152
3. Add a table entry with a link to your project, a binder link, and a short description of what your Docker image contains.
153-
4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request)(PR) with your changes.
153+
4. [Submit a pull request](https://github.com/PointCloudLibrary/pcl/wiki/A-step-by-step-guide-on-preparing-and-submitting-a-pull-request) (PR) with your changes.
154154
Maintainers will respond and work with you to address any formatting or content issues.

docs/using/common.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ You do so by passing arguments to the `docker run` command.
3535

3636
- `-e NB_USER=<username>` - The desired username and associated home folder.
3737
The default value is `jovyan`.
38-
Setting `NB_USER` refits the `jovyan` default user and ensures that the desired user has the correct file permissions
38+
Setting `NB_USER` redefines the `jovyan` default user and ensures that the desired user has the correct file permissions
3939
for the new home directory created at `/home/<username>`.
4040
For this option to take effect, you **must** run the container with `--user root`, set the working directory `-w "/home/<username>"`
4141
and set the environment variable `-e CHOWN_HOME=yes`.
@@ -90,7 +90,7 @@ You do so by passing arguments to the `docker run` command.
9090
While the default `umask` value should be sufficient for most use cases, you can set the `NB_UMASK` value to fit your requirements.
9191

9292
```{note}
93-
`NB_UMASK` when set only applies to the Jupyter process itself -
93+
When `NB_UMASK` is set, it only applies to the Jupyter process itself -
9494
you cannot use it to set a `umask` for additional files created during `run-hooks.sh`.
9595
For example, via `pip` or `conda`.
9696
If you need to set a `umask` for these, you **must** set the `umask` value for each command.
@@ -122,7 +122,7 @@ You do so by passing arguments to the `docker run` command.
122122
- `-e RESTARTABLE=yes` - Runs Jupyter in a loop so that quitting Jupyter does not cause the container to exit.
123123
This may be useful when installing extensions that require restarting Jupyter.
124124
- `-v /some/host/folder/for/work:/home/jovyan/work` - Mounts a host machine directory as a folder in the container.
125-
This configuration is useful for preserving notebooks and other work even after the container is destroyed.
125+
This configuration is useful for preserving notebooks and other work even after the container has been destroyed.
126126
**You must grant the within-container notebook user or group (`NB_UID` or `NB_GID`) write access to the host directory (e.g., `sudo chown 1000 /some/host/folder/for/work`).**
127127
- `-e JUPYTER_ENV_VARS_TO_UNSET=ADMIN_SECRET_1,ADMIN_SECRET_2` - Unsets specified environment variables in the default startup script.
128128
The variables are unset after the hooks have been executed but before the command provided to the startup script runs.
@@ -136,7 +136,7 @@ You do so by passing arguments to the `docker run` command.
136136
You can further customize the container environment by adding shell scripts (`*.sh`) to be sourced
137137
or executables (`chmod +x`) to be run to the paths below:
138138

139-
- `/usr/local/bin/start-notebook.d/` - handled **before** any of the standard options noted above are applied
139+
- `/usr/local/bin/start-notebook.d/` - handled **before** any of the standard options noted above is applied
140140
- `/usr/local/bin/before-notebook.d/` - handled **after** all the standard options noted above are applied
141141
and ran right before the Server launches
142142

@@ -246,7 +246,7 @@ This script is handy when you derive a new Dockerfile from this image and instal
246246

247247
The default Python 3.x [Conda environment](https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/environments.html) resides in `/opt/conda`.
248248
The `/opt/conda/bin` directory is part of the default `jovyan` user's `${PATH}`.
249-
That directory is also searched for binaries when run using `sudo` (`sudo my_binary` will search for `my_binary` in `/opt/conda/bin/`
249+
That directory is also searched for binaries when run using `sudo` (`sudo my_binary` will search for `my_binary` in `/opt/conda/bin/`).
250250

251251
The `jovyan` user has full read/write access to the `/opt/conda` directory.
252252
You can use either `mamba`, `pip`, or `conda` (`mamba` is recommended) to install new packages without any additional permissions.

docs/using/faq.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## How to persist user data
44

5-
There are 2 types of data, which you might want to persist.
5+
There are two types of data, which you might want to persist.
66

77
1. If you want to persist your environment (i.e. packages installed by `mamba`, `conda`, `pip`, `apt-get`, and so on),
88
then you should create an inherited image and install packages only once while building your Dockerfile.
@@ -22,7 +22,7 @@ There are 2 types of data, which you might want to persist.
2222
You can find [an example of using a bind mount here](./running.md#example-2).
2323
There is also [a mount troubleshooting section](./troubleshooting.md#permission-denied-when-mounting-volumes) if you experience any issues.
2424

25-
## Why we do not add your favorite package
25+
## Why we don't add your favorite package
2626

2727
We have lots of users with different packages they want to use.
2828
Adding them all is impossible, so we have several images to choose from.

docs/using/recipes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ docker run -it --rm \
6060
The default version of `Python` that ships with the image may not be the version you want.
6161
The instructions below permit adding a conda environment with a different `Python` version and making it accessible to Jupyter.
6262
You may also use older images like `jupyter/base-notebook:python-3.10`.
63-
A list of all tags can be found [here](https://github.com/jupyter/docker-stacks/wiki)
63+
A list of all tags can be found [here](https://github.com/jupyter/docker-stacks/wiki).
6464

6565
```{literalinclude} recipe_code/custom_environment.dockerfile
6666
:language: docker
@@ -400,7 +400,7 @@ docker run -it --rm \
400400
## Enable nbclassic-extension spellchecker for markdown (or any other nbclassic-extension)
401401

402402
```{note}
403-
This recipe only works for NBCassic with Jupyter Notebook < 7.
403+
This recipe only works for NBClassic with Jupyter Notebook < 7.
404404
It is recommended to use [jupyterlab-spellchecker](https://github.com/jupyterlab-contrib/spellchecker) in modern environments.
405405
```
406406

docs/using/selecting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ It contains:
244244
We provide CUDA accelerated versions of the `pytorch-notebook` and `tensorflow-notebook` images.
245245
Prepend a CUDA prefix (versioned prefix like `cuda12-` for `pytorch-notebook` or just `cuda-` for `tensorflow-notebook`) to the image tag
246246
to allow PyTorch or TensorFlow operations to use compatible NVIDIA GPUs for accelerated computation.
247-
We only build `pytorch-notebook` for last two major versions of CUDA.
247+
We only build `pytorch-notebook` for the last two major versions of CUDA.
248248
The `tensorflow-notebook` image only supports the latest CUDA version listed in the [officially tested build configurations](https://www.tensorflow.org/install/source#gpu).
249249

250250
For example, you could use the image `quay.io/jupyter/pytorch-notebook:cuda12-python-3.11.8` or `quay.io/jupyter/tensorflow-notebook:cuda-latest`.

0 commit comments

Comments
 (0)