Skip to content

Conversation

@dictcp
Copy link

@dictcp dictcp commented Nov 18, 2025

Enable CUDA build for ARM64

Since there are ARM64 platform like DGX spark, we need CUDA build for ARM64.
(give DGX spark case, given it requires CUDA capacity of 12.1, so latest CUDA is fine)

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

Copilot AI review requested due to automatic review settings November 18, 2025 17:00
@dictcp dictcp closed this Nov 18, 2025
Copilot finished reviewing on behalf of dictcp November 18, 2025 17:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables CUDA build support for ARM64 (aarch64) platforms to support hardware like NVIDIA DGX Spark systems. The changes add ARM64 CUDA build configurations for both TensorFlow and PyTorch notebooks.

  • Adds aarch64-tensorflow-cuda job for building CUDA-enabled TensorFlow notebooks on ARM64
  • Adds aarch64-pytorch-cuda12 job for building CUDA-enabled PyTorch notebooks on ARM64 with CUDA 12
  • Updates the tag-push job dependencies to include the new ARM64 CUDA build jobs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +217 to +227
aarch64-tensorflow-cuda:
uses: ./.github/workflows/docker-build-test-upload.yml
with:
parent-image: scipy-notebook
image: tensorflow-notebook
variant: cuda
platform: aarch64
runs-on: ubuntu-24.04-arm
timeout-minutes: 25
needs: aarch64-scipy
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md file should be updated to reflect that CUDA builds are now available for ARM64 platforms. Currently, lines 104-105 in README.md state that CUDA variants are only available for x86_64 platform, which will be inaccurate after this PR is merged.

Suggested addition to README.md around line 105:

- Starting from `2025-XX-XX`, we create CUDA enabled variants of `pytorch-notebook` and `tensorflow-notebook` images for `aarch64` platform

Copilot uses AI. Check for mistakes.
@dictcp
Copy link
Author

dictcp commented Nov 18, 2025

replaced by #2352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant