test everything

Author: blink1073

.github/actions/test-downstream/action.yml

@@ -22,7 +22,7 @@ runs:
           package_spec=${package_spec:-"${{inputs.package_name}}[test]"}
           pytest_args="${{inputs.pytest_args}}"
           pytest_args=${pytest_args:-"--pyargs ${{inputs.package_name}}"}
-          env_values=${{ inputs.env_values }}
+          eval ${{inputs.env_values}}
 
           # Set up venv
           python -m venv test_venv
@@ -32,10 +32,6 @@ runs:
           ${bin_dir}/python -m pip install . --force-reinstall
 
           # Test the downstream package
-          if [ -z ${env_values} ]; then
-            eval ${env_values}
-          fi
-
           ${bin_dir}/pytest ${pytest_args}
 
           # Cleanup

.github/workflows/downstream.yml

@@ -17,7 +17,29 @@ jobs:
       - name: Base Setup
         uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
 
-      - name: Test Ipykernel
+      - name: Test IPykernel
         uses: ./.github/actions/test-downstream
         with:
           package_name: ipykernel
+          package_spec: "pyqt5 ipykernel[test]"
+
+      - name: Test NBClient
+        uses: ./.github/actions/test-downstream
+        with:
+          package_name: nbclient
+          env_values: "IPYKERNEL_CELL_NAME="<IPY-INPUT>"
+
+      - name: Test QtConsole
+        uses: ./.github/actions/test-downstream
+        with:
+          package_name: qtconsole
+
+      - name: Test nbconvert
+        uses: ./.github/actions/test-downstream
+        with:
+          package_name: nbconvert
+
+      - name: Test jupyter_server
+        uses: ./.github/actions/test-downstream
+        with:
+          package_name: jupyter_server