fix test and fix loop handling

Author: blink1073

jupyter_client/channels.py

@@ -109,6 +109,7 @@ def run(self) -> None:
         loop = asyncio.new_event_loop()
         asyncio.set_event_loop(loop)
         loop.run_until_complete(self._async_run())
+        loop.close()
 
     async def _async_run(self) -> None:
         """The thread's main activity.  Call start() instead."""

jupyter_client/tests/test_kernelmanager.py

@@ -194,13 +194,15 @@ async def test_async_signal_kernel_subprocesses(self, name, install, expected):
 class TestKernelManager:
     def test_lifecycle(self, km):
         km.start_kernel(stdout=PIPE, stderr=PIPE)
+        kc = km.client()
         assert km.is_alive()
         is_done = km.ready.done()
         assert is_done
         km.restart_kernel(now=True)
         assert km.is_alive()
         km.interrupt_kernel()
         assert isinstance(km, KernelManager)
+        kc.stop_channels()
         km.shutdown_kernel(now=True)
         assert km.context.closed
 

jupyter_client/tests/test_multikernelmanager.py

@@ -88,9 +88,11 @@ def _run_lifecycle(km, test_kid=None):
         assert kid in km.list_kernel_ids()
         km.interrupt_kernel(kid)
         k = km.get_kernel(kid)
+        kc = k.client()
         assert isinstance(k, KernelManager)
         km.shutdown_kernel(kid, now=True)
         assert kid not in km, f"{kid} not in {km}"
+        kc.stop_channels()
 
     def _run_cinfo(self, km, transport, ip):
         kid = km.start_kernel(stdout=PIPE, stderr=PIPE)
@@ -415,10 +417,6 @@ async def test_use_pending_kernels_early_shutdown(self):
         kernel = km.get_kernel(kid)
         assert not kernel.ready.done()
         # Try shutting down while the kernel is pending
-        with pytest.raises(RuntimeError):
-            await ensure_future(km.shutdown_kernel(kid, now=True))
-        await kernel.ready
-        # Shutdown once the kernel is ready
         await ensure_future(km.shutdown_kernel(kid, now=True))
         # Wait for the kernel to shutdown
         await kernel.ready
@@ -476,6 +474,7 @@ def tcp_lifecycle_with_loop(self):
         loop = asyncio.new_event_loop()
         asyncio.set_event_loop(loop)
         loop.run_until_complete(self.raw_tcp_lifecycle())
+        loop.close()
 
     # static so picklable for multiprocessing on Windows
     @classmethod
@@ -491,6 +490,7 @@ def raw_tcp_lifecycle_sync(cls, test_kid=None):
         loop = asyncio.new_event_loop()
         asyncio.set_event_loop(loop)
         loop.run_until_complete(cls.raw_tcp_lifecycle(test_kid=test_kid))
+        loop.close()
 
     @gen_test
     async def test_start_parallel_thread_kernels(self):

jupyter_client/threaded.py

@@ -243,6 +243,9 @@ def stop(self) -> None:
         self.close()
         self.ioloop = None
 
+    def __del__(self):
+        self.close()
+
     def close(self) -> None:
         if self.ioloop is not None:
             try:

jupyter_client/utils.py

@@ -4,6 +4,7 @@
 - vendor functions from ipython_genutils that should be retired at some point.
 """
 import asyncio
+import atexit
 import inspect
 import os
 
@@ -14,6 +15,7 @@ def wrapped(*args, **kwargs):
             loop = asyncio.get_running_loop()
         except RuntimeError:
             loop = asyncio.new_event_loop()
+            atexit.register(loop.close)
             asyncio.set_event_loop(loop)
         import nest_asyncio  # type: ignore
 

pyproject.toml

@@ -41,10 +41,6 @@ filterwarnings= [
   # Fail on warnings
   "error",
 
-  # Workarounds for https://github.com/pytest-dev/pytest-asyncio/issues/77
-  "ignore:unclosed <socket.socket:ResourceWarning",
-  "ignore:unclosed event loop:ResourceWarning",
-
   # Workaround for https://github.com/tornadoweb/tornado/issues/3106
   # (To be fixed in Tornado 6.2)
   "ignore:There is no current event loop:DeprecationWarning:tornado",