Allow provisioner to affect stable start time

Author: vidartf

jupyter_client/ioloop/restarter.py

@@ -92,8 +92,13 @@ async def poll(self):
             # restarter. Therefore, we use "has been alive continuously for X time" as a
             # heuristic for a stable start up.
             # See https://github.com/jupyter/jupyter_client/pull/717 for details.
-            if self._initial_startup and self._last_dead - now >= self.stable_start_time:
+            stable_start_time = self.stable_start_time
+            if self.kernel_manager.provisioner:
+                stable_start_time = self.kernel_manager.provisioner.get_stable_start_time(
+                    recommended=stable_start_time
+                )
+            if self._initial_startup and self._last_dead - now >= stable_start_time:
                 self._initial_startup = False
-            if self._restarting and self._last_dead - now >= self.stable_start_time:
+            if self._restarting and self._last_dead - now >= stable_start_time:
                 self.log.debug("AsyncIOLoopKernelRestarter: restart apparently succeeded")
                 self._restarting = False

jupyter_client/provisioning/provisioner_base.py

@@ -206,7 +206,7 @@ async def load_provisioner_info(self, provisioner_info: Dict) -> None:
 
     def get_shutdown_wait_time(self, recommended: float = 5.0) -> float:
         """
-        Returns the time allowed for a complete shutdown.  This may vary by provisioner.
+        Returns the time allowed for a complete shutdown. This may vary by provisioner.
 
         This method is called from `KernelManager.finish_shutdown()` during the graceful
         phase of its kernel shutdown sequence.
@@ -215,6 +215,15 @@ def get_shutdown_wait_time(self, recommended: float = 5.0) -> float:
         """
         return recommended
 
+    def get_stable_start_time(self, recommended: float = 10.0) -> float:
+        """
+        Returns the expected upper bound for a kernel (re-)start to complete.
+        This may vary by provisioner.
+
+        The recommended value will typically be what is configured in the kernel restarter.
+        """
+        return recommended
+
     def _finalize_env(self, env: Dict[str, str]) -> None:
         """
         Ensures env is appropriate prior to launch.

jupyter_client/restarter.py

@@ -150,8 +150,13 @@ def poll(self):
             # restarter. Therefore, we use "has been alive continuously for X time" as a
             # heuristic for a stable start up.
             # See https://github.com/jupyter/jupyter_client/pull/717 for details.
-            if self._initial_startup and self._last_dead - now >= self.stable_start_time:
+            stable_start_time = self.stable_start_time
+            if self.kernel_manager.provisioner:
+                stable_start_time = self.kernel_manager.provisioner.get_stable_start_time(
+                    recommended=stable_start_time
+                )
+            if self._initial_startup and self._last_dead - now >= stable_start_time:
                 self._initial_startup = False
-            if self._restarting and self._last_dead - now >= self.stable_start_time:
+            if self._restarting and self._last_dead - now >= stable_start_time:
                 self.log.debug("KernelRestarter: restart apparently succeeded")
                 self._restarting = False