Skip to content

Commit 2fae25b

Browse files
authored
Merge pull request #379 from mpacer/config_kernel_manager
make KernelManager configurable for all who inherit JupyterConsoleApp
2 parents b754994 + f1d8a95 commit 2fae25b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

jupyter_client/consoleapp.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from traitlets.config.application import boolean_flag
1919
from ipython_genutils.path import filefind
2020
from traitlets import (
21-
Dict, List, Unicode, CUnicode, CBool, Any
21+
Dict, List, Unicode, CUnicode, CBool, Any, Type
2222
)
2323

2424
from jupyter_core.application import base_flags, base_aliases
@@ -110,7 +110,11 @@ class JupyterConsoleApp(ConnectionFileMixin):
110110
classes = classes
111111
flags = Dict(flags)
112112
aliases = Dict(aliases)
113-
kernel_manager_class = KernelManager
113+
kernel_manager_class = Type(
114+
default_value=KernelManager,
115+
config=True,
116+
help='The kernel manager class to use.'
117+
)
114118
kernel_client_class = BlockingKernelClient
115119

116120
kernel_argv = List(Unicode())

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def run(self):
9595
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*',
9696
extras_require = {
9797
'test': ['ipykernel', 'ipython', 'mock'],
98-
'test:python_version == "3.3"': ['pytest<3.3.0'],
98+
'test:python_version == "3.3"': ['pytest>=3,<3.3.0'],
9999
'test:(python_version >= "3.4" or python_version == "2.7")': ['pytest'],
100100
},
101101
cmdclass = {

0 commit comments

Comments
 (0)