Merge pull request #234 from jasongrout/buffers

Check that buffers in a session send support the buffer protocol.

Author: rgbkrk

jupyter_client/session.py

@@ -699,6 +699,14 @@ def send(self, stream, msg_or_type, content=None, parent=None, ident=None,
             )
             return
         buffers = [] if buffers is None else buffers
+        for buf in buffers:
+            if not isinstance(buf, memoryview):
+                try:
+                    # check to see if buf supports the buffer protocol.
+                    memoryview(buf)
+                except TypeError:
+                    raise TypeError("Buffer objects must support the buffer protocol.")
+
         if self.adapt_version:
             msg = adapt(msg, self.adapt_version)
         to_send = self.serialize(msg, ident)

jupyter_client/tests/test_session.py

@@ -121,6 +121,10 @@ def test_send(self):
         self.assertEqual(new_msg['parent_header'],msg['parent_header'])
         self.assertEqual(new_msg['buffers'],[b'bar'])
 
+        # buffers must support the buffer protocol
+        with self.assertRaises(TypeError) as cm:
+            self.session.send(A, msg, ident=b'foo', buffers=[1])
+
         A.close()
         B.close()
         ctx.term()